From: Guenter Roeck <linux@roeck-us.net>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
gnomes@lxorguk.ukuu.org.uk, Rik van Riel <riel@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
thomas.lendacky@amd.com, Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jiri Kosina <jikos@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Dave Hansen <dave.hansen@intel.com>,
Kees Cook <keescook@google.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linux-foundation.org>,
Paul Turner <pjt@google.com>
Subject: Re: [PATCH v2] x86/retpoline: Add clang support
Date: Wed, 7 Feb 2018 15:32:11 -0800 [thread overview]
Message-ID: <20180207233211.GA13991@roeck-us.net> (raw)
In-Reply-To: <1518042518.3677.153.camel@infradead.org>
On Wed, Feb 07, 2018 at 10:28:38PM +0000, David Woodhouse wrote:
>
>
> On Wed, 2018-02-07 at 13:52 -0800, Guenter Roeck wrote:
> > clang has its own set of compiler options for retpoline support.
> >
> > Link: https://github.com/llvm-mirror/clang/commit/0d816739a82da29748caf88570affb9715e18b69
> > Link: https://github.com/llvm-mirror/llvm/commit/fd5a8723ce9f2a6b250e85972ef859e4253ea95d
> > Link: https://github.com/llvm-mirror/llvm/commit/59b64490fda69d29bb42cfdf7eec37bcc31ff833
> > Cc: David Woodhouse <dwmw@amazon.co.uk>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: gnomes@lxorguk.ukuu.org.uk
> > Cc: Rik van Riel <riel@redhat.com>
> > Cc: Andi Kleen <ak@linux.intel.com>
> > Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> > Cc: thomas.lendacky@amd.com
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Jiri Kosina <jikos@kernel.org>
> > Cc: Andy Lutomirski <luto@amacapital.net>
> > Cc: Dave Hansen <dave.hansen@intel.com>
> > Cc: Kees Cook <keescook@google.com>
> > Cc: Tim Chen <tim.c.chen@linux.intel.com>
> > Cc: Greg Kroah-Hartman <gregkh@linux-foundation.org>
> > Cc: Paul Turner <pjt@google.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > v2: llvm has been updated to use the same thunk names as gcc.
> > Tested with:
> > clang version 7.0.0
> > (https://git.llvm.org/git/clang.git/
> > 848874aed95a913fb45f363120500cebfe54e2ef)
> > (https://git.llvm.org/git/llvm.git/
> > 3afd566557f3616881505db0d69f5d19bf55ae14)
> > cross-checked with gcc 7.3.0 (x86_64-linux-gcc.br_real (Buildroot
> > 2018.02-rc1) 7.3.0).
> >
> > Tested with 64-bit builds only; 32-bit images fail to build with clang
> > with various unrelated errors and are difficult to test.
> >
> > I had to change '+=' to '=' below since make otherwise sets
> > RETPOLINE_CFLAGS to " ", and the subsequent ifneq would always match.
> > This is also the reason for the "ifeq ($(RETPOLINE_CFLAGS),)".
> > If there is another/different/better way to handle this, please let
> > me know.
>
> See
> http://git.infradead.org/users/dwmw2/linux-retpoline.git/commitdiff/82a1f41600
>
You have __x86_indirect_thunk within #ifdef CONFIG_64BIT.
I think it should be in the else case.
Guenter
next prev parent reply other threads:[~2018-02-07 23:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 21:52 [PATCH v2] x86/retpoline: Add clang support Guenter Roeck
2018-02-07 22:28 ` David Woodhouse
2018-02-07 23:28 ` Guenter Roeck
2018-02-07 23:32 ` Guenter Roeck [this message]
2018-02-13 23:41 ` Guenter Roeck
2018-02-14 0:10 ` David Woodhouse
2018-02-14 2:18 ` Guenter Roeck
2018-02-14 13:09 ` David Woodhouse
2018-02-14 16:09 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207233211.GA13991@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ak@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw2@infradead.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linux-foundation.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox