Re: [PATCH 3/3] hid: logitech-dj: delete unnecessary error messages

Marcus Folkesson
2018-02-08T07:57:24Z

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

Hello Christoph,

On Wed, Feb 07, 2018 at 06:08:00PM +0100, Christoph Böhmwalder wrote:
> Remove some "out of memory" messages that are considered useless.
>
> Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at>
> ---
> drivers/hid/hid-logitech-dj.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index 59c54cb4bc64..ba5239840cda 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -414,11 +414,8 @@ static void logi_dj_recv_add_djhid_device(struct dj_receiver_dev *djrcv_dev,
>
> dj_dev = kzalloc(sizeof(*dj_dev), GFP_KERNEL);
>
> - if (!dj_dev) {
> - dev_err(&djrcv_hdev->dev, "%s: failed allocating dj_device\n",
> - __func__);
> + if (!dj_dev)
> goto dj_device_allocate_fail;
> - }
>
> dj_dev->reports_supported =
> get_unaligned_le32(dj_report->report_params
> @@ -1015,11 +1012,9 @@ static int logi_dj_probe(struct hid_device *hdev,
> /* Treat interface 2 */
>
> djrcv_dev = kzalloc(sizeof(*djrcv_dev), GFP_KERNEL);
> - if (!djrcv_dev) {
> - dev_err(&hdev->dev,
> - "%s:failed allocating dj_receiver_dev\n", __func__);
> + if (!djrcv_dev)
> return -ENOMEM;
> - }
> +
> djrcv_dev->hdev = hdev;
> INIT_WORK(&djrcv_dev->work, delayedwork_callback);
> spin_lock_init(&djrcv_dev->lock);
> --
> 2.13.6
>

Thank you, but Markus Elfring already has a submitted a patch for this one.

/Marcus

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]