From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751796AbeBHLA6 (ORCPT ); Thu, 8 Feb 2018 06:00:58 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:55492 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752233AbeBHLAz (ORCPT ); Thu, 8 Feb 2018 06:00:55 -0500 X-Google-Smtp-Source: AH8x225cDJzrkBXN86c7vZeXwqidSRkmiExycDbCzE4YO/dbAUl5WWiFQ7SNje+zlXFJR/KEe9LLCg== Date: Thu, 8 Feb 2018 12:00:52 +0100 From: Christoffer Dall To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, kristina.martsenko@arm.com, peter.maydell@linaro.org, pbonzini@redhat.com, rkrcmar@redhat.com, will.deacon@arm.com, ard.biesheuvel@linaro.org, mark.rutland@arm.com, catalin.marinas@arm.com, Christoffer Dall Subject: Re: [PATCH v1 07/16] kvm: arm/arm64: Remove spurious WARN_ON Message-ID: <20180208110052.GJ29286@cbox> References: <20180109190414.4017-1-suzuki.poulose@arm.com> <20180109190414.4017-8-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180109190414.4017-8-suzuki.poulose@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 09, 2018 at 07:04:02PM +0000, Suzuki K Poulose wrote: > On a 4-level page table pgd entry can be empty, unlike a 3-level > page table. Remove the spurious WARN_ON() in stage_get_pud(). Acked-by: Christoffer Dall > > Cc: Marc Zyngier > Cc: Christoffer Dall > Signed-off-by: Suzuki K Poulose > --- > virt/kvm/arm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c > index e6548c85c495..78253fe00fc4 100644 > --- a/virt/kvm/arm/mmu.c > +++ b/virt/kvm/arm/mmu.c > @@ -870,7 +870,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm, struct kvm_mmu_memory_cache *cache > pud_t *pud; > > pgd = kvm->arch.pgd + stage2_pgd_index(addr); > - if (WARN_ON(stage2_pgd_none(*pgd))) { > + if (stage2_pgd_none(*pgd)) { > if (!cache) > return NULL; > pud = mmu_memory_cache_alloc(cache); > -- > 2.13.6 >