public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
	douly.fnst@cn.fujitsu.com, joro@8bytes.org, uobergfe@redhat.com,
	prarit@redhat.com
Subject: Re: [PATCH v2 1/2] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel
Date: Thu, 8 Feb 2018 20:34:18 +0800	[thread overview]
Message-ID: <20180208123418.GG30270@localhost.localdomain> (raw)
In-Reply-To: <87eflwa8d5.fsf@xmission.com>

On 02/07/18 at 01:48pm, Eric W. Biederman wrote:
> ebiederm@xmission.com (Eric W. Biederman) writes:

> > Now that I see that I agree in essence with this patch series.
> > I don't agree with the implemenation details.
> >
> > Can you please split disable_IO_APIC and switch_to_legacy_irq_mode
> > in a single patch.
> 
> Now that I think about it can you call the function not
> switch_to_legacy_irq_mode but restore_boot_irq_mode.  And the
> corresponding x86_io_apic_ops not .disable but .restore.
> 
> That should make the purpose of the code clearer, and help avoid
> mistakes like the one that led to this regression.

Thanks for your comments and great suggestion. Have made change as you
suggested, will post after test passed.

Thanks
Baoquan

  reply	other threads:[~2018-02-08 12:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25 14:11 [PATCH v2 0/2] x86/apic/kexec: Legacy irq setting fixs in kdump kernel Baoquan He
2018-01-25 14:11 ` [PATCH v2 1/2] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel Baoquan He
2018-02-07 17:11   ` Eric W. Biederman
2018-02-07 17:35     ` Eric W. Biederman
2018-02-07 19:48       ` Eric W. Biederman
2018-02-08 12:34         ` Baoquan He [this message]
2018-01-25 14:11 ` [PATCH v2 2/2] x86/apic: Set up through-local-APIC on boot CPU's LINT0 if 'noapic' specified Baoquan He
2018-02-02  4:04 ` [PATCH v2 0/2] x86/apic/kexec: Legacy irq setting fixs in kdump kernel Dou Liyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180208123418.GG30270@localhost.localdomain \
    --to=bhe@redhat.com \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=prarit@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=uobergfe@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox