Re: [PATCH 1/3] x86/MCE/AMD: Redo function to get SMCA bank type

Borislav Petkov
2018-02-08T15:04:56Z

On Thu, Feb 01, 2018 at 12:48:11PM -0600, Yazen Ghannam wrote:
> arch/x86/kernel/cpu/mcheck/mce_amd.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c
> index 0f32ad242324..4e16afc0794d 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c
> @@ -110,14 +110,14 @@ const char *smca_get_long_name(enum smca_bank_types t)
> }
> EXPORT_SYMBOL_GPL(smca_get_long_name);
>
> -static enum smca_bank_types smca_get_bank_type(struct mce *m)
> +static enum smca_bank_types smca_get_bank_type(unsigned int bank)
> {
> struct smca_bank *b;
>
> - if (m->bank >= N_SMCA_BANK_TYPES)
> + if (bank >= ARRAY_SIZE(smca_banks))

MAX_NR_BANKS

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.