From: Stephen Hemminger <stephen@networkplumber.org>
To: Michael Kelley <mhkelley@outlook.com>
Cc: "olaf@aepfle.de" <olaf@aepfle.de>,
"sthemmin@microsoft.com" <sthemmin@microsoft.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mikelley@microsoft.com" <mikelley@microsoft.com>,
"marcelo.cerri@canonical.com" <marcelo.cerri@canonical.com>,
"apw@canonical.com" <apw@canonical.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"leann.ogasawara@canonical.com" <leann.ogasawara@canonical.com>
Subject: Re: [PATCH char-misc 1/1] Drivers: hv: vmbus: Fix ring buffer signaling
Date: Sun, 11 Feb 2018 15:50:47 -0800 [thread overview]
Message-ID: <20180211155047.7859be96@xeon-e3> (raw)
In-Reply-To: <SN6PR1901MB204572CAD3159EB07D6F1043CBF10@SN6PR1901MB2045.namprd19.prod.outlook.com>
On Sat, 10 Feb 2018 20:48:49 +0000
Michael Kelley <mhkelley@outlook.com> wrote:
> + u32 delta = rbi->ring_buffer->read_index < rbi->priv_read_index ?
> + (rbi->priv_read_index - rbi->ring_buffer->read_index) :
> + (rbi->ring_datasize - rbi->ring_buffer->read_index +
> + rbi->priv_read_index);
>
Would it would make sense for this to be a wrapper function like other ring operations?
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-02-11 23:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 20:48 [PATCH char-misc 1/1] Drivers: hv: vmbus: Fix ring buffer signaling Michael Kelley
2018-02-11 23:50 ` Stephen Hemminger [this message]
2018-02-12 1:14 ` KY Srinivasan
2018-02-12 5:13 ` Michael Kelley (EOSG)
2018-02-13 17:34 ` Stephen Hemminger
2018-02-14 2:12 ` Michael Kelley (EOSG)
2018-02-14 18:12 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180211155047.7859be96@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mhkelley@outlook.com \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox