From: Namhyung Kim <namhyung@kernel.org>
To: Sangwon Hong <qpakzk@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Taeung Song <treeze.taeung@gmail.com>,
kernel-team@lge.com
Subject: Re: [PATCH] perf kallsyms: Fix the usage on the man page
Date: Mon, 12 Feb 2018 10:50:21 +0900 [thread overview]
Message-ID: <20180212015021.GB31513@sejong> (raw)
In-Reply-To: <1518377864-20353-1-git-send-email-qpakzk@gmail.com>
On Mon, Feb 12, 2018 at 04:37:44AM +0900, Sangwon Hong wrote:
> First, all man pages highlight only perf and subcommands except perf
> kallsyms, which includes the full usage. Fix it for commands to monopolize
> underlines.
>
> Second, options can skip when executing perf kallsyms, so add square
> brackets between <option>.
>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Taeung Song <treeze.taeung@gmail.com>
> Signed-off-by: Sangwon Hong <qpakzk@gmail.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/Documentation/perf-kallsyms.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/perf-kallsyms.txt b/tools/perf/Documentation/perf-kallsyms.txt
> index 954ea9e..cf9f404 100644
> --- a/tools/perf/Documentation/perf-kallsyms.txt
> +++ b/tools/perf/Documentation/perf-kallsyms.txt
> @@ -8,7 +8,7 @@ perf-kallsyms - Searches running kernel for symbols
> SYNOPSIS
> --------
> [verse]
> -'perf kallsyms <options> symbol_name[,symbol_name...]'
> +'perf kallsyms' [<options>] symbol_name[,symbol_name...]
>
> DESCRIPTION
> -----------
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-02-12 1:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 19:37 [PATCH] perf kallsyms: Fix the usage on the man page Sangwon Hong
2018-02-12 1:50 ` Namhyung Kim [this message]
2018-02-21 12:25 ` Arnaldo Carvalho de Melo
2018-03-06 6:40 ` [tip:perf/core] " tip-bot for Sangwon Hong
2018-03-07 8:24 ` [tip:perf/urgent] " tip-bot for Sangwon Hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212015021.GB31513@sejong \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qpakzk@gmail.com \
--cc=treeze.taeung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).