From: Juri Lelli <juri.lelli@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
vincent.guittot@linaro.org, luca.abeni@santannapisa.it,
claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it,
bristot@redhat.com, mathieu.poirier@linaro.org,
tkjos@android.com, joelaf@google.com, morten.rasmussen@arm.com,
dietmar.eggemann@arm.com, patrick.bellasi@arm.com,
alessio.balsini@arm.com
Subject: Re: [RFC PATCH 1/3] sched/deadline: merge dl_bw into dl_bandwidth
Date: Mon, 12 Feb 2018 19:17:31 +0100 [thread overview]
Message-ID: <20180212181731.GO12979@localhost.localdomain> (raw)
In-Reply-To: <20180212130239.506cbce9@gandalf.local.home>
On 12/02/18 13:02, Steven Rostedt wrote:
> On Mon, 12 Feb 2018 18:43:12 +0100
> Juri Lelli <juri.lelli@redhat.com> wrote:
>
> > However, this surely needs to be fixed here. It's tracking the sum of
> > all tasks' (across CPUs) bandwidth admitted on the system, so that's why
> > it's called dl_total_bw. Incremented when a task passes sched_setattr()
> > and decremented when it leaves the system or changes scheduling class.
> >
> > Does it make a bit more sense? Would you still prefer a different name?
>
> No the name is fine, the comment needs to change.
>
> - dl_total_bw - tracks the sum of all tasks' bandwidth across CPUs.
>
> How's that?
LGTM. I'll fix in next version.
Thanks!
- Juri
next prev parent reply other threads:[~2018-02-12 18:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 13:40 [RFC PATCH 0/3] SCHED_DEADLINE cgroups support Juri Lelli
2018-02-12 13:40 ` [RFC PATCH 1/3] sched/deadline: merge dl_bw into dl_bandwidth Juri Lelli
2018-02-12 17:34 ` Steven Rostedt
2018-02-12 17:43 ` Juri Lelli
2018-02-12 18:02 ` Steven Rostedt
2018-02-12 18:17 ` Juri Lelli [this message]
2018-02-12 13:40 ` [RFC PATCH 2/3] sched/deadline: add task groups bandwidth management support Juri Lelli
2018-02-12 16:47 ` Tejun Heo
2018-02-12 17:09 ` Juri Lelli
2018-02-12 13:40 ` [RFC PATCH 3/3] Documentation/scheduler/sched-deadline: add info about cgroup support Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212181731.GO12979@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=alessio.balsini@arm.com \
--cc=bristot@redhat.com \
--cc=claudio@evidence.eu.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tkjos@android.com \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox