From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934426AbeBMKcV (ORCPT ); Tue, 13 Feb 2018 05:32:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:57587 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933849AbeBMKcP (ORCPT ); Tue, 13 Feb 2018 05:32:15 -0500 Date: Tue, 13 Feb 2018 11:32:13 +0100 From: Michal Hocko To: Michael Ellerman Cc: Kees Cook , Will Drewry , linux-s390 , PowerPC , LKML Subject: Re: samples/seccomp/ broken when cross compiling s390, ppc allyesconfig Message-ID: <20180213103213.GP3443@dhcp22.suse.cz> References: <20180212133731.GE3443@dhcp22.suse.cz> <87r2ppvaeq.fsf@concordia.ellerman.id.au> <87d1192nzc.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d1192nzc.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 13-02-18 21:16:55, Michael Ellerman wrote: > Kees Cook writes: > > > On Mon, Feb 12, 2018 at 7:25 PM, Michael Ellerman wrote: > >> Michal Hocko writes: > >>> Hi, > >>> my build test machinery chokes on samples/seccomp when cross compiling > >>> s390 and ppc64 allyesconfig. This has been the case for quite some > >>> time already but I never found time to look at the problem and report > >>> it. It seems this is not new issue and similar thing happend for > >>> MIPS e9107f88c985 ("samples/seccomp/Makefile: do not build tests if > >>> cross-compiling for MIPS"). > >>> > >>> The build logs are attached. > >>> > >>> What is the best way around this? Should we simply skip compilation on > >>> cross compile or is actually anybody relying on that? Or should I simply > >>> disable it for s390 and ppc? > >> > >> The whole thing seems very confused. It's not building for the target, > >> it's building for the host, ie. the Makefile sets hostprogs-m and > >> HOSTCFLAGS etc. > >> > >> So it can't possibly work with cross compiling as it's currently > >> written. > >> > >> Either the Makefile needs some serious work to properly support cross > >> compiling or it should just be disabled when cross compiling. > > > > Hrm, yeah, the goal was to entirely disable cross compiling, but I > > guess we didn't hit it with a hard enough hammer. :) > > Do you know why it is written that way? Why doesn't it just try to cross > compile like normal code? No idea, sorry. All I know about this code is that it breaks my build testing. -- Michal Hocko SUSE Labs