From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode/intel: Use 64-bit arithmetic instead of 32-bit
Date: Tue, 13 Feb 2018 23:18:47 +0000 [thread overview]
Message-ID: <20180213231847.36f87c0b@alans-desktop> (raw)
In-Reply-To: <alpine.DEB.2.21.1802131747290.1130@nanos.tec.linutronix.de>
> if (c->x86_cache_size >= 0)
> seq_printf(m, "cache size\t: %d KB\n", c->x86_cache_size);
>
> which is silly, because that really can be done with:
>
> if (c->x86_cache_size)
>
> as there is no point in printing 'cache size 0KB', which means
> x86_cache_size can be made unsigned int, which makes sense because cache
> size < 0 does not at all.
Currently 0MB means "I know you have no cache" (early slot 1 celeron),
while not printing it means 'I have no clue'
Alan
next prev parent reply other threads:[~2018-02-13 23:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 16:44 [PATCH] x86/microcode/intel: Use 64-bit arithmetic instead of 32-bit Gustavo A. R. Silva
2018-02-13 17:02 ` Thomas Gleixner
2018-02-13 17:24 ` Gustavo A. R. Silva
2018-02-13 23:18 ` Alan Cox [this message]
2018-02-14 11:39 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213231847.36f87c0b@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=bp@alien8.de \
--cc=garsilva@embeddedor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox