From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966857AbeBNFro (ORCPT ); Wed, 14 Feb 2018 00:47:44 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49420 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754405AbeBNFrm (ORCPT ); Wed, 14 Feb 2018 00:47:42 -0500 From: Baoquan He To: linux-kernel@vger.kernel.org, ebiederm@xmission.com Cc: mingo@kernel.org, tglx@linutronix.de, x86@kernel.org, douly.fnst@cn.fujitsu.com, joro@8bytes.org, uobergfe@redhat.com, prarit@redhat.com, Baoquan He Subject: [PATCH v5 6/6] x86/apic: Set up through-local-APIC on boot CPU if 'noapic' specified Date: Wed, 14 Feb 2018 13:46:56 +0800 Message-Id: <20180214054656.3780-7-bhe@redhat.com> In-Reply-To: <20180214054656.3780-1-bhe@redhat.com> References: <20180214054656.3780-1-bhe@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently kdump kernel becomes very slow if 'noapic' is specified. Normal kernel won't. Kernel parameter 'noapic' is used to disable IO-APIC in system for testing or special purpose. Here the root cause is that in kdump kernel LAPIC is disabled since commit 522e664644 ("x86/apic: Disable I/O APIC before shutdown of the local APIC"). In this case We need set up through-local-APIC on boot CPU in setup_local_APIC(). While In normal kernel the legacy irq mode is enabled in BIOS. If it is virtual wire mode, the local-APIC has been enabled and set as through-local-APIC. Though we fix the regression introduced by criminal commit 522e664644, for safety and clarity, better set up through-local-APIC explicitly, but not rely on the default boot irq mode. Do it now. Signed-off-by: Baoquan He --- arch/x86/kernel/apic/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 25ddf02598d2..3fc259b4dd2d 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1570,7 +1570,7 @@ void setup_local_APIC(void) * TODO: set up through-local-APIC from through-I/O-APIC? --macro */ value = apic_read(APIC_LVT0) & APIC_LVT_MASKED; - if (!cpu && (pic_mode || !value)) { + if (!cpu && (pic_mode || !value || skip_ioapic_setup)) { value = APIC_DM_EXTINT; apic_printk(APIC_VERBOSE, "enabled ExtINT on CPU#%d\n", cpu); } else { -- 2.13.6