[PATCH V3 01/10] sched/topology: Add check to backup comment about hotplug lock

Mathieu Poirier
2018-02-13T20:35:27Z

The comment above function partition_sched_domains() clearly state that
the cpu_hotplug_lock should be held but doesn't mandate one to abide to
it. Adding an explicit check backs that comment and make it impossible
for anyone to miss the requirement.

Suggested-by: Juri Lelli <juri.lelli@redhat.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
kernel/sched/topology.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 8010c2974d30..7c744c7425ec 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1863,6 +1863,7 @@ void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
int i, j, n;
int new_topology;

+ lockdep_assert_cpus_held();
mutex_lock(&sched_domains_mutex);

/* Always unregister in case we don't destroy any domains: */
--
2.7.4