From: James Hogan <jhogan@kernel.org>
To: Mathieu Malaterre <malat@debian.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Marcin Nowakowski <marcin.nowakowski@mips.com>,
Miodrag Dinic <miodrag.dinic@mips.com>,
Aleksandar Markovic <aleksandar.markovic@mips.com>,
David Daney <david.daney@cavium.com>,
linux-mips@linux-mips.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] MIPS: Remove a warning when PHYS_OFFSET is 0x0
Date: Wed, 14 Feb 2018 13:59:43 +0000 [thread overview]
Message-ID: <20180214135943.GG4290@saruman> (raw)
In-Reply-To: <CA+7wUsyNrLzd0fM5B4_89wp8G9g=VHLu=xQ3o4bK47PLv4p1LQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]
On Wed, Feb 14, 2018 at 11:35:44AM +0100, Mathieu Malaterre wrote:
> On Tue, Jan 2, 2018 at 7:55 PM, Mathieu Malaterre <malat@debian.org> wrote:
> > Hi James,
> >
> > On Tue, Jan 2, 2018 at 10:31 AM, James Hogan <james.hogan@mips.com> wrote:
> >> On Tue, Dec 26, 2017 at 12:37:14PM +0100, Mathieu Malaterre wrote:
> >>> Rewrite the comparison in `else if` statement, case where `min_low_pfn >
> >>> ARCH_PFN_OFFSET` has already been checked in the first `if` statement:
> >>>
> >>> if (min_low_pfn > ARCH_PFN_OFFSET) {
> >>>
> >>> Fix non-fatal warning:
> >>>
> >>> arch/mips/kernel/setup.c: In function ‘bootmem_init’:
> >>> arch/mips/kernel/setup.c:461:25: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> >>> } else if (min_low_pfn < ARCH_PFN_OFFSET) {
> >>> ^
> >>
> >> What compiler version is that with out of interest? It isn't exactly new
> >> code.
> >
> > I've clarified in v2, that this happen during compilation using W=1
> >
> > For reference:
> >
> > $ mipsel-linux-gnu-gcc -dumpversion
> > 6.3.0
> >
> >
> >>>
> >>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> >>
> >> Reviewed-by: James Hogan <jhogan@kernel.org>
> >
> > Thanks !
>
> ping ?
>
> https://patchwork.linux-mips.org/project/linux-mips/list/?series=623
Yep, both applied for 4.17.
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-14 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 11:37 [PATCH 1/2] MIPS: add declaration for function `memory_region_available` Mathieu Malaterre
2017-12-26 11:37 ` [PATCH 2/2] MIPS: Remove a warning when PHYS_OFFSET is 0x0 Mathieu Malaterre
2018-01-02 9:31 ` James Hogan
2018-01-02 18:55 ` Mathieu Malaterre
2018-02-14 10:35 ` Mathieu Malaterre
2018-02-14 13:59 ` James Hogan [this message]
2018-01-02 18:53 ` [PATCH v2 " Mathieu Malaterre
2018-01-02 9:51 ` [PATCH 1/2] MIPS: add declaration for function `memory_region_available` James Hogan
2018-01-02 18:52 ` [PATCH v2 1/2] MIPS: Make declaration for function `memory_region_available` static Mathieu Malaterre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214135943.GG4290@saruman \
--to=jhogan@kernel.org \
--cc=aleksandar.markovic@mips.com \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=malat@debian.org \
--cc=marcin.nowakowski@mips.com \
--cc=miodrag.dinic@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox