Re: [PATCH] p9caps: add Plan9 capability devices

Enrico Weigelt, metux IT consult
2018-02-13T12:40:20Z

On 13.02.2018 07:16, Serge E. Hallyn wrote:
>> + /* make sure only one instance per namespace can be opened */ > > ... at a time
yeah, right.

> might be better to keep this state in the user_ns itself, would
> avoid kzalloc below.

thought about, but hesitated to touch user_ns. might not be the best
idea when having p9caps as module (OTOH, doesn't need to be a module)

the whole thing might become a bit more complex when introducing
plan9-like unprivileged mount operations. haven't sorted out how to
do that yet.

> Would it be worth doing any privilege checking here?

Which ones should I check ?

--mtx