* [PATCH -next v4] mtd: nand: toshiba: Retrieve ECC requirements from extended ID
@ 2018-02-14 15:35 KOBAYASHI Yoshitake
2018-02-14 19:15 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: KOBAYASHI Yoshitake @ 2018-02-14 15:35 UTC (permalink / raw)
To: boris.brezillon, richard, dwmw2, computersforpeace, marek.vasut,
cyrille.pitchen, linux-mmc
Cc: linux-kernel, KOBAYASHI Yoshitake
This patch enables support to read the ECC strength and size from the
NAND flash using Toshiba Memory SLC NAND extended-ID. This patch is
based on the information of the 6th ID byte of the Toshiba Memory SLC
NAND.
Signed-off-by: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
---
drivers/mtd/nand/nand_toshiba.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/mtd/nand/nand_toshiba.c b/drivers/mtd/nand/nand_toshiba.c
index 57df857..ab43f02 100644
--- a/drivers/mtd/nand/nand_toshiba.c
+++ b/drivers/mtd/nand/nand_toshiba.c
@@ -35,6 +35,32 @@ static void toshiba_nand_decode_id(struct nand_chip *chip)
(chip->id.data[5] & 0x7) == 0x6 /* 24nm */ &&
!(chip->id.data[4] & 0x80) /* !BENAND */)
mtd->oobsize = 32 * mtd->writesize >> 9;
+
+ /*
+ * Extract ECC requirements from 6th id byte.
+ * For Toshiba SLC, ecc requrements are as follows:
+ * - 43nm: 1 bit ECC for each 512Byte is required.
+ * - 32nm: 4 bit ECC for each 512Byte is required.
+ * - 24nm: 8 bit ECC for each 512Byte is required.
+ */
+ if (chip->id.len >= 6 && nand_is_slc(chip)) {
+ chip->ecc_step_ds = 512;
+ switch (chip->id.data[5] & 0x7) {
+ case 0x4:
+ chip->ecc_strength_ds = 1;
+ break;
+ case 0x5:
+ chip->ecc_strength_ds = 4;
+ break;
+ case 0x6:
+ chip->ecc_strength_ds = 8;
+ break;
+ default:
+ WARN(1, "Could not get ECC info");
+ chip->ecc_step_ds = 0;
+ break;
+ }
+ }
}
static int toshiba_nand_init(struct nand_chip *chip)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next v4] mtd: nand: toshiba: Retrieve ECC requirements from extended ID
2018-02-14 15:35 [PATCH -next v4] mtd: nand: toshiba: Retrieve ECC requirements from extended ID KOBAYASHI Yoshitake
@ 2018-02-14 19:15 ` Boris Brezillon
2018-02-14 19:29 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Boris Brezillon @ 2018-02-14 19:15 UTC (permalink / raw)
To: KOBAYASHI Yoshitake
Cc: boris.brezillon, richard, dwmw2, computersforpeace, marek.vasut,
cyrille.pitchen, linux-mtd@lists.infradead.org, linux-kernel
-linux-mmc
+linux-mtd
On Thu, 15 Feb 2018 00:35:06 +0900
KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp> wrote:
> This patch enables support to read the ECC strength and size from the
> NAND flash using Toshiba Memory SLC NAND extended-ID. This patch is
> based on the information of the 6th ID byte of the Toshiba Memory SLC
> NAND.
This version looks good to me.
>
> Signed-off-by: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
> ---
> drivers/mtd/nand/nand_toshiba.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/mtd/nand/nand_toshiba.c b/drivers/mtd/nand/nand_toshiba.c
> index 57df857..ab43f02 100644
> --- a/drivers/mtd/nand/nand_toshiba.c
> +++ b/drivers/mtd/nand/nand_toshiba.c
> @@ -35,6 +35,32 @@ static void toshiba_nand_decode_id(struct nand_chip *chip)
> (chip->id.data[5] & 0x7) == 0x6 /* 24nm */ &&
> !(chip->id.data[4] & 0x80) /* !BENAND */)
> mtd->oobsize = 32 * mtd->writesize >> 9;
> +
> + /*
> + * Extract ECC requirements from 6th id byte.
> + * For Toshiba SLC, ecc requrements are as follows:
> + * - 43nm: 1 bit ECC for each 512Byte is required.
> + * - 32nm: 4 bit ECC for each 512Byte is required.
> + * - 24nm: 8 bit ECC for each 512Byte is required.
> + */
> + if (chip->id.len >= 6 && nand_is_slc(chip)) {
> + chip->ecc_step_ds = 512;
> + switch (chip->id.data[5] & 0x7) {
> + case 0x4:
> + chip->ecc_strength_ds = 1;
> + break;
> + case 0x5:
> + chip->ecc_strength_ds = 4;
> + break;
> + case 0x6:
> + chip->ecc_strength_ds = 8;
> + break;
> + default:
> + WARN(1, "Could not get ECC info");
> + chip->ecc_step_ds = 0;
> + break;
> + }
> + }
> }
>
> static int toshiba_nand_init(struct nand_chip *chip)
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next v4] mtd: nand: toshiba: Retrieve ECC requirements from extended ID
2018-02-14 19:15 ` Boris Brezillon
@ 2018-02-14 19:29 ` Boris Brezillon
0 siblings, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2018-02-14 19:29 UTC (permalink / raw)
To: KOBAYASHI Yoshitake
Cc: boris.brezillon, richard, dwmw2, computersforpeace, marek.vasut,
cyrille.pitchen, linux-mtd@lists.infradead.org, linux-kernel
On Wed, 14 Feb 2018 20:15:41 +0100
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> -linux-mmc
> +linux-mtd
>
> On Thu, 15 Feb 2018 00:35:06 +0900
> KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp> wrote:
>
> > This patch enables support to read the ECC strength and size from the
> > NAND flash using Toshiba Memory SLC NAND extended-ID. This patch is
> > based on the information of the 6th ID byte of the Toshiba Memory SLC
> > NAND.
>
> This version looks good to me.
>
Applied.
Thanks,
Boris
> >
> > Signed-off-by: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
> > ---
> > drivers/mtd/nand/nand_toshiba.c | 26 ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/nand_toshiba.c b/drivers/mtd/nand/nand_toshiba.c
> > index 57df857..ab43f02 100644
> > --- a/drivers/mtd/nand/nand_toshiba.c
> > +++ b/drivers/mtd/nand/nand_toshiba.c
> > @@ -35,6 +35,32 @@ static void toshiba_nand_decode_id(struct nand_chip *chip)
> > (chip->id.data[5] & 0x7) == 0x6 /* 24nm */ &&
> > !(chip->id.data[4] & 0x80) /* !BENAND */)
> > mtd->oobsize = 32 * mtd->writesize >> 9;
> > +
> > + /*
> > + * Extract ECC requirements from 6th id byte.
> > + * For Toshiba SLC, ecc requrements are as follows:
> > + * - 43nm: 1 bit ECC for each 512Byte is required.
> > + * - 32nm: 4 bit ECC for each 512Byte is required.
> > + * - 24nm: 8 bit ECC for each 512Byte is required.
> > + */
> > + if (chip->id.len >= 6 && nand_is_slc(chip)) {
> > + chip->ecc_step_ds = 512;
> > + switch (chip->id.data[5] & 0x7) {
> > + case 0x4:
> > + chip->ecc_strength_ds = 1;
> > + break;
> > + case 0x5:
> > + chip->ecc_strength_ds = 4;
> > + break;
> > + case 0x6:
> > + chip->ecc_strength_ds = 8;
> > + break;
> > + default:
> > + WARN(1, "Could not get ECC info");
> > + chip->ecc_step_ds = 0;
> > + break;
> > + }
> > + }
> > }
> >
> > static int toshiba_nand_init(struct nand_chip *chip)
>
>
>
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-14 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-14 15:35 [PATCH -next v4] mtd: nand: toshiba: Retrieve ECC requirements from extended ID KOBAYASHI Yoshitake
2018-02-14 19:15 ` Boris Brezillon
2018-02-14 19:29 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox