From: Patrick Bellasi <patrick.bellasi@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
valentin.schneider@arm.com, morten.rasmussen@foss.arm.com,
brendan.jackman@arm.com, dietmar.eggemann@arm.com
Subject: Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed
Date: Thu, 15 Feb 2018 16:59:43 +0000 [thread overview]
Message-ID: <20180215165943.GA21994@e110439-lin> (raw)
In-Reply-To: <20180215165028.GA25181@hirez.programming.kicks-ass.net>
On 15-Feb 17:50, Peter Zijlstra wrote:
> On Thu, Feb 15, 2018 at 03:22:47PM +0000, Patrick Bellasi wrote:
> > > > static struct {
> > > > cpumask_var_t idle_cpus_mask;
> > > > atomic_t nr_cpus;
> > > > + int has_blocked; /* Idle CPUS has blocked load */
> >
> > Why not "bool"?
> >
> Because then he gets me yelling that sizeof(_Bool) is undefined and the
> whole structure layout goes out the window :-)
Now I know...
> Never use bool in a composite type.
... got a note ;-)
--
#include <best/regards.h>
Patrick Bellasi
next prev parent reply other threads:[~2018-02-15 16:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 15:26 [PATCH v5 0/3] sched: Update blocked load Vincent Guittot
2018-02-14 15:26 ` [PATCH v5 1/3] sched: Stop nohz stats when decayed Vincent Guittot
2018-02-15 15:22 ` Patrick Bellasi
2018-02-15 16:50 ` Peter Zijlstra
2018-02-15 16:59 ` Patrick Bellasi [this message]
2018-02-15 17:06 ` Vincent Guittot
2018-02-16 12:13 ` Valentin Schneider
2018-02-16 13:44 ` Vincent Guittot
2018-02-21 13:13 ` Valentin Schneider
2018-02-21 13:48 ` Valentin Schneider
2018-02-22 8:37 ` Vincent Guittot
2018-02-22 10:04 ` Valentin Schneider
2018-02-16 12:53 ` Valentin Schneider
2018-02-16 17:02 ` Vincent Guittot
2018-02-16 19:23 ` Valentin Schneider
2018-02-14 15:26 ` [PATCH v5 2/3] sched: reduce the periodic update duration Vincent Guittot
2018-02-14 15:26 ` [PATCH v5 3/3] sched: update blocked load when newly idle Vincent Guittot
2018-02-20 11:59 ` Peter Zijlstra
2018-03-09 9:06 ` [tip:sched/core] sched/fair: Update " tip-bot for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215165943.GA21994@e110439-lin \
--to=patrick.bellasi@arm.com \
--cc=brendan.jackman@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@foss.arm.com \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).