From: Alexey Dobriyan <adobriyan@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm 1/3] proc: randomize "struct pde_opener"
Date: Fri, 16 Feb 2018 07:41:15 +0300 [thread overview]
Message-ID: <20180216044115.GA7811@avx2> (raw)
In-Reply-To: <CAGXu5jKv5EehXn7tNc9n=Zd_tT5AcNeQm5_rT81m6OAWXXpMYQ@mail.gmail.com>
On Thu, Feb 15, 2018 at 04:53:29PM -0800, Kees Cook wrote:
> On Wed, Feb 14, 2018 at 12:19 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > The more the merrier.
>
> What made you choose this structure, BTW?
Nothing depends on its layout. No funky memcpy/memset...
It is strange you didn't annotate like 95% of structs.
> > @@ -177,7 +177,7 @@ struct pde_opener {
> > struct list_head lh;
> > bool closing;
> > struct completion *c;
> > -};
> > +} __randomize_layout;
prev parent reply other threads:[~2018-02-16 4:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 6:30 [PATCH -mm] proc: faster open/close of files without ->release hook Alexey Dobriyan
2018-02-14 8:19 ` [PATCH -mm 1/3] proc: randomize "struct pde_opener" Alexey Dobriyan
2018-02-14 8:23 ` [PATCH -mm 2/3] proc: move "struct pde_opener" to kmem cache Alexey Dobriyan
2018-02-14 8:24 ` [PATCH -mm 3/3] proc: account "struct pde_opener" Alexey Dobriyan
2018-02-15 19:07 ` [PATCH -mm 1/3] proc: randomize " Al Viro
2018-02-15 21:41 ` Alexey Dobriyan
2018-02-16 0:13 ` Al Viro
2018-02-16 1:03 ` Kees Cook
2018-02-16 4:48 ` Alexey Dobriyan
2018-02-16 0:53 ` Kees Cook
2018-02-16 4:41 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216044115.GA7811@avx2 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox