Re: [PATCH v4 3/4] arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP

Rajendra Nayak
2018-02-22T07:57:14Z

On 02/22/2018 04:53 AM, Doug Anderson wrote:
> Hi,
>
> On Mon, Feb 19, 2018 at 8:36 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>>> + interrupts = <GIC_SPI 208 IRQ_TYPE_NONE>;
>>
>> Please do not use IRQ_TYPE_NONE, ever. It doesn't exist in the GIC
>> binding. Set it to the actual trigger value.
>>
>
>>> + interrupts = <GIC_SPI 481 IRQ_TYPE_NONE>;
>>
>> Same here.
>
> Thanks for the review Marc!
>
>
> Andy: If I'm reading everything correctly you're the one who would
> collect these patches and apply them. Is that right? Do they look OK
> to you in general? Would you prefer that Rajendra send out a v5 with
> the fixes pointed out by Marc, or would you prefer to fix them up
> yourself when applying? Is now a good time or would you prefer to
> wait?

I just fixed up to remove all instances of IRQ_TYPE_NONE and sent a v5 out.

>
> Thanks! :)
>
> -Doug
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation