public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Tejun Heo <tj@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Jason Baron <jbaron@akamai.com>, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH 3/3] percpu: Remove inert tracepoint in __init code
Date: Fri, 16 Feb 2018 10:02:33 +0100	[thread overview]
Message-ID: <20180216090233.lpuqu4z4co6zy5rb@gmail.com> (raw)
In-Reply-To: <20180215153341.5zlc2opvx2vteoqe@treble>


* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Thu, Feb 15, 2018 at 07:22:46AM -0800, Tejun Heo wrote:
> > On Wed, Feb 14, 2018 at 10:40:43AM -0600, Josh Poimboeuf wrote:
> > > The jump_label code doesn't patch init code, so this tracepoint can
> > > never be enabled.  Remove it.
> > > 
> > > Cc: Tejun Heo <tj@kernel.org>
> > > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> > 
> > Applied to percpu/for-4.17.
> 
> Actually, I think this patch should be dropped.  As Jason pointed out,
> tracepoints *can* be enabled at boot time for __init code, so it's
> possible for this tracepoint to be used.

Would it still be useful to have the warning for failed patching?

Thanks,

	Ingo

  reply	other threads:[~2018-02-16  9:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 16:40 [PATCH 0/3] jump_label: Robustify jump label patching Josh Poimboeuf
2018-02-14 16:40 ` [PATCH 1/3] jump_label: Warn on failed jump_label patch Josh Poimboeuf
2018-02-14 17:01   ` Steven Rostedt
2018-02-14 17:18     ` Jason Baron
2018-02-14 17:34       ` Josh Poimboeuf
2018-02-14 17:40         ` Steven Rostedt
2018-02-14 21:17           ` Josh Poimboeuf
2018-02-15 22:35             ` Josh Poimboeuf
2018-02-16 17:31               ` Steven Rostedt
2018-02-14 17:01   ` Borislav Petkov
2018-02-14 16:40 ` [PATCH 2/3] x86/xen: Remove inert tracepoint in __init code Josh Poimboeuf
2018-02-14 16:49   ` Juergen Gross
2018-02-14 16:40 ` [PATCH 3/3] percpu: " Josh Poimboeuf
2018-02-15 15:22   ` Tejun Heo
2018-02-15 15:33     ` Josh Poimboeuf
2018-02-16  9:02       ` Ingo Molnar [this message]
2018-02-16 12:52         ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180216090233.lpuqu4z4co6zy5rb@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@suse.de \
    --cc=jbaron@akamai.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox