Re: [PATCH 04/12] usb: common: Small class for USB role switches

Hans de Goede
2018-02-25T12:16:30Z

Hi,

On 16-02-18 19:33, Randy Dunlap wrote:
> On 02/16/2018 02:47 AM, Hans de Goede wrote:
>> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>>
>
>> diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c
>> new file mode 100644
>> index 000000000000..923e3721d183
>> --- /dev/null
>> +++ b/drivers/usb/common/roles.c
>> @@ -0,0 +1,305 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/**
>
> Just use /* since this is not kernel-doc notation.

Thank you for catching this, fixed for v2.

Regards,

Hans

>
>> + * USB Role Switch Support
>> + *
>> + * Copyright (C) 2018 Intel Corporation
>> + * Author: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> + * Hans de Goede <hdegoede@redhat.com>
>> + */
>
>