From: Greg KH <gregkh@linuxfoundation.org>
To: Yisheng Xie <xieyisheng1@huawei.com>
Cc: devel@driverdev.osuosl.org, sumit.semwal@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/9] staging: android: ion: Remove lable debugfs_done
Date: Fri, 16 Feb 2018 17:27:56 +0100 [thread overview]
Message-ID: <20180216162756.GB18688@kroah.com> (raw)
In-Reply-To: <1518432194-41536-6-git-send-email-xieyisheng1@huawei.com>
On Mon, Feb 12, 2018 at 06:43:10PM +0800, Yisheng Xie wrote:
> When failed to create debug_root, we will go on initail other part of
> ion, so we can just info this message to user and do not need a lable
> to jump.
>
> Acked-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> ---
> drivers/staging/android/ion/ion.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 4b69372..461b193 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -595,12 +595,9 @@ static int ion_device_create(void)
> }
>
> idev->debug_root = debugfs_create_dir("ion", NULL);
> - if (!idev->debug_root) {
> + if (!idev->debug_root)
> pr_err("ion: failed to create debugfs root directory.\n");
> - goto debugfs_done;
> - }
Again, does not matter to check the return value of any debugfs call.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-02-16 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 10:43 [PATCH v2 0/9] staging: android: ion: Some cleanup about ion Yisheng Xie
2018-02-12 10:43 ` [PATCH v2 1/9] staging: android: ion: Remove unused declaration ion_buffer_fault_user_mappings Yisheng Xie
2018-02-12 10:43 ` [PATCH v2 2/9] staging: android: ion: Remove unused include files for ion_page_pool.c Yisheng Xie
2018-02-12 10:43 ` [PATCH v2 3/9] staging: android: ion: Nuke ion_page_pool_init Yisheng Xie
2018-02-12 10:43 ` [PATCH v2 4/9] staging: android: ion: Avoid NULL point in error path Yisheng Xie
2018-02-16 16:27 ` Greg KH
2018-02-22 8:59 ` Yisheng Xie
2018-02-22 9:13 ` Greg KH
2018-02-12 10:43 ` [PATCH v2 5/9] staging: android: ion: Remove lable debugfs_done Yisheng Xie
2018-02-16 16:27 ` Greg KH [this message]
2018-02-12 10:43 ` [PATCH v2 6/9] staging: android: ion: Remove dead code in ion_page_pool_free Yisheng Xie
2018-02-12 10:43 ` [PATCH v2 7/9] staging: android: ion: Return void instead of int Yisheng Xie
2018-02-12 10:43 ` [PATCH v2 8/9] staging: android: ion: Cleanup ion_page_pool_alloc_pages Yisheng Xie
2018-02-12 10:43 ` [PATCH v2 9/9] staging: android: ion: Combine cache and uncache pools Yisheng Xie
2018-02-12 11:17 ` [PATCH v2 0/9] staging: android: ion: Some cleanup about ion Dan Carpenter
2018-02-12 11:33 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216162756.GB18688@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox