From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751032AbeBQL2U (ORCPT ); Sat, 17 Feb 2018 06:28:20 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:43178 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750771AbeBQL2T (ORCPT ); Sat, 17 Feb 2018 06:28:19 -0500 Date: Sat, 17 Feb 2018 19:28:14 +0800 From: Baoquan He To: Ingo Molnar Cc: ebiederm@xmission.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, douly.fnst@cn.fujitsu.com, joro@8bytes.org, uobergfe@redhat.com, prarit@redhat.com Subject: Re: [PATCH v5 0/6] x86/apic: Fix restoring boot irq mode in reboot and kexec/kdump Message-ID: <20180217112814.GA22626@localhost.localdomain> References: <20180214054656.3780-1-bhe@redhat.com> <20180216093836.v6iq32jycy7sxwln@gmail.com> <20180216102437.GA28912@localhost.localdomain> <20180217104649.5xuzspdqkt6zjcud@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180217104649.5xuzspdqkt6zjcud@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17/18 at 11:46am, Ingo Molnar wrote: > > * Baoquan He wrote: > > > Thanks for checking this! > > > > I got warning message from kbuild test robot on previous v3 and v4. I > > guess this v5 post also has the issue since the code is the same, just > > patch format is changed. > > > > Will report status after investigation. > > Well, your patches didn't build when CONFIG_IO_APIC is disabled - I have fixed > this by the patch below. > > Thanks, > > Ingo > > --- > arch/x86/include/asm/io_apic.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/include/asm/io_apic.h b/arch/x86/include/asm/io_apic.h > index 06fec4426458..fd20a2334885 100644 > --- a/arch/x86/include/asm/io_apic.h > +++ b/arch/x86/include/asm/io_apic.h > @@ -233,6 +233,7 @@ static inline void io_apic_init_mappings(void) { } > > static inline void setup_IO_APIC(void) { } > static inline void enable_IO_APIC(void) { } > +static inline void restore_boot_irq_mode(void) { } Ah, yes, thanks. Ack this patch. Acked-by: Baoquan He