Re: [PATCH 1/2] vsprintf: distinguish between (null), (err) and (invalid) pointer derefs

Andy Shevchenko
2018-03-07T13:29:35Z

On Tue, 2018-03-06 at 19:11 +0100, Adam Borowski wrote:
> Attempting to print an object pointed to by a bad (usually ERR_PTR)
> pointer
> is a not so surprising error. Our code handles them inconsistently:
> * two places print (null) if ptr<PAGE_SIZE
> * one place prints (null) if abs(ptr)<PAGE_SIZE
> * one place prints (null) only if !ptr
>
> Obviously, saying (null) for a small but non-0 value is misleading.
> Thus, let's print:
> * (null) for exactly 0
> * (err) if last page && abs(ptr)<=MAX_ERRNO
> * (invalid) otherwise

Ah, and last but not least thing.
Where are the test cases?

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy