From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbeBSKt7 (ORCPT ); Mon, 19 Feb 2018 05:49:59 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42334 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752392AbeBSKty (ORCPT ); Mon, 19 Feb 2018 05:49:54 -0500 Date: Mon, 19 Feb 2018 11:49:44 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Ingo Molnar , David Ahern , Alexander Shishkin , Peter Zijlstra , kernel-team@lge.com Subject: Re: [PATCH 6/9] perf tools: Don't search for active kernel start in __machine__create_kernel_maps Message-ID: <20180219104917.GA19365@krava> References: <20180215122635.24029-1-jolsa@kernel.org> <20180215122635.24029-7-jolsa@kernel.org> <20180219022036.GB1583@sejong> <20180219100140.GA17630@krava> <20180219101936.GD1583@sejong> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180219101936.GD1583@sejong> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 19, 2018 at 07:19:36PM +0900, Namhyung Kim wrote: SNIP > From b736729e83b62f97d716a011ccf4e430b614fecd Mon Sep 17 00:00:00 2001 > From: Namhyung Kim > Date: Mon, 19 Feb 2018 19:00:46 +0900 > Subject: [PATCH] perf tools: Fix paranoid check in machine__set_kernel_mmap() > > The machine__set_kernel_mmap() is to setup addresses of the kernel map > using external info. But it has a check when the address is given > from an incorrect input which should have the start and end address of > 0 (i.e. machine__process_kernel_mmap_event). > > But we also use the end address of 0 for a valid input so change it to > check both start and end addresses. > > Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/util/machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index fe27ef55cbb9..12b7427444a3 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1226,7 +1226,7 @@ static void machine__set_kernel_mmap(struct machine *machine, > * Be a bit paranoid here, some perf.data file came with > * a zero sized synthesized MMAP event for the kernel. > */ > - if (machine->vmlinux_maps[i]->end == 0) > + if (start == 0 && end == 0) > machine->vmlinux_maps[i]->end = ~0ULL; > } > } > -- > 2.16.1 >