From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
George Cherian <george.cherian@cavium.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, Jayachandran.Nair@cavium.com,
Robert.Richter@cavium.com,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH] PCI: Add quirk for Cavium Thunder-X2 PCIe erratum #173
Date: Tue, 20 Feb 2018 02:54:33 +0100 [thread overview]
Message-ID: <20180220015433.GA9656@wunner.de> (raw)
In-Reply-To: <2858019.9TUCWsDpTB@aspire.rjw.lan>
On Mon, Feb 19, 2018 at 12:21:56PM +0100, Rafael J. Wysocki wrote:
> On Friday, February 16, 2018 9:34:34 PM CET Bjorn Helgaas wrote:
> > On Fri, Feb 16, 2018 at 01:40:37PM +0100, Rafael J. Wysocki wrote:
> > > On Friday, February 16, 2018 12:39:00 AM CET Bjorn Helgaas wrote:
> > > > On Thu, Feb 15, 2018 at 10:57:25PM +0100, Rafael J. Wysocki wrote:
> > > > > On Wednesday, February 14, 2018 9:16:53 PM CET Bjorn Helgaas wrote:
> > > > > > I don't know how this runtime PM works, but maybe Rafael can help
> > > > > > us out.
This has nothing to do with runtime PM AFAICS.
The device seems to be in D3hot on boot, is that correct?
The PCI core assumes that unbound devices remain in D0
(see comments in pci_pm_runtime_resume() / pci_pm_runtime_suspend()).
> > > > > I'm not sure what the question is to be honest.
> > > >
> > > > My questions are basically "What does the PCI core need to do to make
> > > > sure a device is in D0 before it operates on it? And where do we need
> > > > to do that?"
When scanning the bus and discovering the device is not in D0,
call pci_power_up(). This could probably go into pci_init_pm().
Once a driver binds to it, it may choose to runtime suspend it to
D3hot again.
Just an idea anyway.
Thanks,
Lukas
next prev parent reply other threads:[~2018-02-20 1:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 7:00 [PATCH] PCI: Add quirk for Cavium Thunder-X2 PCIe erratum #173 George Cherian
2018-02-13 6:23 ` Jayachandran C
2018-02-13 15:09 ` Bjorn Helgaas
2018-02-14 11:28 ` George Cherian
2018-02-14 20:16 ` Bjorn Helgaas
2018-02-15 21:57 ` Rafael J. Wysocki
2018-02-15 23:39 ` Bjorn Helgaas
2018-02-16 12:40 ` Rafael J. Wysocki
2018-02-16 20:34 ` Bjorn Helgaas
2018-02-19 11:21 ` Rafael J. Wysocki
2018-02-19 20:36 ` Bjorn Helgaas
2018-02-20 1:54 ` Lukas Wunner [this message]
2018-02-20 10:58 ` Rafael J. Wysocki
2018-02-20 19:00 ` Bjorn Helgaas
2018-02-21 9:28 ` George Cherian
2018-02-21 9:54 ` Lukas Wunner
2018-02-21 10:55 ` George Cherian
2018-02-21 23:20 ` Bjorn Helgaas
2018-02-22 8:35 ` Lukas Wunner
2018-02-22 10:19 ` Rafael J. Wysocki
2018-02-22 13:13 ` George Cherian
2018-02-22 15:09 ` Bjorn Helgaas
2018-03-13 14:13 ` George Cherian
2018-02-19 19:08 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220015433.GA9656@wunner.de \
--to=lukas@wunner.de \
--cc=Jayachandran.Nair@cavium.com \
--cc=Robert.Richter@cavium.com \
--cc=bhelgaas@google.com \
--cc=george.cherian@cavium.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox