From: Alexandre Courbot <acourbot@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Pawel Osciak <posciak@chromium.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomasz Figa <tfiga@chromium.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Gustavo Padovan <gustavo.padovan@collabora.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot <acourbot@chromium.org>
Subject: [RFCv4 20/21] media: vivid: add request support for the video capture device
Date: Tue, 20 Feb 2018 13:44:24 +0900 [thread overview]
Message-ID: <20180220044425.169493-21-acourbot@chromium.org> (raw)
In-Reply-To: <20180220044425.169493-1-acourbot@chromium.org>
Allow to use requests with the video capture device.
Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
---
drivers/media/platform/vivid/Kconfig | 1 +
drivers/media/platform/vivid/vivid-core.c | 63 ++++++++++++++++++-
drivers/media/platform/vivid/vivid-core.h | 3 +
.../media/platform/vivid/vivid-kthread-cap.c | 17 +++++
4 files changed, 83 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/vivid/Kconfig b/drivers/media/platform/vivid/Kconfig
index 154de92dd809..a6494dabae95 100644
--- a/drivers/media/platform/vivid/Kconfig
+++ b/drivers/media/platform/vivid/Kconfig
@@ -7,6 +7,7 @@ config VIDEO_VIVID
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
+ select MEDIA_REQUEST_API
select VIDEOBUF2_VMALLOC
select VIDEOBUF2_DMA_CONTIG
select VIDEO_V4L2_TPG
diff --git a/drivers/media/platform/vivid/vivid-core.c b/drivers/media/platform/vivid/vivid-core.c
index 82ec216f2ad8..c1cf8e7ca2c9 100644
--- a/drivers/media/platform/vivid/vivid-core.c
+++ b/drivers/media/platform/vivid/vivid-core.c
@@ -23,6 +23,7 @@
#include <media/v4l2-ioctl.h>
#include <media/v4l2-fh.h>
#include <media/v4l2-event.h>
+#include <media/v4l2-request.h>
#include "vivid-core.h"
#include "vivid-vid-common.h"
@@ -486,6 +487,33 @@ static const struct v4l2_file_operations vivid_fops = {
.mmap = vb2_fop_mmap,
};
+static int vivid_cap_open(struct file *filp)
+{
+ struct vivid_dev *dev;
+ struct v4l2_fh *fh;
+ int ret;
+
+ ret = v4l2_fh_open(filp);
+ if (ret)
+ return ret;
+
+ dev = container_of(video_devdata(filp), struct vivid_dev, vid_cap_dev);
+ fh = filp->private_data;
+ fh->entity = &dev->vid_cap_req_entity.base;
+
+ return ret;
+}
+
+static const struct v4l2_file_operations vivid_cap_fops = {
+ .owner = THIS_MODULE,
+ .open = vivid_cap_open,
+ .release = vivid_fop_release,
+ .read = vb2_fop_read,
+ .write = vb2_fop_write,
+ .poll = vb2_fop_poll,
+ .unlocked_ioctl = video_ioctl2,
+ .mmap = vb2_fop_mmap,
+};
static const struct v4l2_file_operations vivid_radio_fops = {
.owner = THIS_MODULE,
.open = v4l2_fh_open,
@@ -607,6 +635,31 @@ static const struct v4l2_ioctl_ops vivid_ioctl_ops = {
.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
};
+struct media_request_entity_data *
+vid_cap_entity_data_alloc(struct media_request *req,
+ struct media_request_entity *entity)
+{
+ struct vivid_dev *dev;
+
+ dev = container_of(entity, struct vivid_dev, vid_cap_req_entity.base);
+ return v4l2_request_entity_data_alloc(req, &dev->ctrl_hdl_vid_cap);
+}
+
+static int vid_cap_request_submit(struct media_request *req,
+ struct media_request_entity_data *_data)
+{
+ struct v4l2_request_entity_data *data;
+
+ data = to_v4l2_entity_data(_data);
+ return vb2_request_submit(data);
+}
+
+static const struct media_request_entity_ops vivid_request_entity_ops = {
+ .data_alloc = vid_cap_entity_data_alloc,
+ .data_free = v4l2_request_entity_data_free,
+ .submit = vid_cap_request_submit,
+};
+
/* -----------------------------------------------------------------
Initialization and module stuff
------------------------------------------------------------------*/
@@ -1057,6 +1110,7 @@ static int vivid_create_instance(struct platform_device *pdev, int inst)
q->mem_ops = vivid_mem_ops[allocator];
q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
q->min_buffers_needed = 2;
+ q->allow_requests = true;
q->lock = &dev->mutex;
q->dev = dev->v4l2_dev.dev;
@@ -1158,13 +1212,19 @@ static int vivid_create_instance(struct platform_device *pdev, int inst)
vfd = &dev->vid_cap_dev;
snprintf(vfd->name, sizeof(vfd->name),
"vivid-%03d-vid-cap", inst);
- vfd->fops = &vivid_fops;
+ vfd->fops = &vivid_cap_fops;
vfd->ioctl_ops = &vivid_ioctl_ops;
vfd->device_caps = dev->vid_cap_caps;
vfd->release = video_device_release_empty;
vfd->v4l2_dev = &dev->v4l2_dev;
vfd->queue = &dev->vb_vid_cap_q;
vfd->tvnorms = tvnorms_cap;
+ vfd->req_mgr = &dev->vid_cap_req_mgr.base;
+ v4l2_request_mgr_init(&dev->vid_cap_req_mgr, vfd,
+ &v4l2_request_ops);
+ v4l2_request_entity_init(&dev->vid_cap_req_entity,
+ &vivid_request_entity_ops,
+ vfd);
/*
* Provide a mutex to v4l2 core. It will be used to protect
@@ -1448,6 +1508,7 @@ static int vivid_remove(struct platform_device *pdev)
v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
video_device_node_name(&dev->vid_cap_dev));
video_unregister_device(&dev->vid_cap_dev);
+ v4l2_request_mgr_free(&dev->vid_cap_req_mgr);
}
if (dev->has_vid_out) {
v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
diff --git a/drivers/media/platform/vivid/vivid-core.h b/drivers/media/platform/vivid/vivid-core.h
index 477c80a4d44c..c8adcbb1c1d1 100644
--- a/drivers/media/platform/vivid/vivid-core.h
+++ b/drivers/media/platform/vivid/vivid-core.h
@@ -11,6 +11,7 @@
#include <linux/fb.h>
#include <linux/workqueue.h>
#include <media/cec.h>
+#include <media/v4l2-request.h>
#include <media/videobuf2-v4l2.h>
#include <media/v4l2-device.h>
#include <media/v4l2-dev.h>
@@ -145,6 +146,8 @@ struct vivid_dev {
struct v4l2_ctrl_handler ctrl_hdl_fb;
struct video_device vid_cap_dev;
struct v4l2_ctrl_handler ctrl_hdl_vid_cap;
+ struct v4l2_request_mgr vid_cap_req_mgr;
+ struct v4l2_request_entity vid_cap_req_entity;
struct video_device vid_out_dev;
struct v4l2_ctrl_handler ctrl_hdl_vid_out;
struct video_device vbi_cap_dev;
diff --git a/drivers/media/platform/vivid/vivid-kthread-cap.c b/drivers/media/platform/vivid/vivid-kthread-cap.c
index 3fdb280c36ca..0d0866dc11b3 100644
--- a/drivers/media/platform/vivid/vivid-kthread-cap.c
+++ b/drivers/media/platform/vivid/vivid-kthread-cap.c
@@ -19,6 +19,7 @@
#include <linux/random.h>
#include <linux/v4l2-dv-timings.h>
#include <asm/div64.h>
+#include <media/media-request.h>
#include <media/videobuf2-vmalloc.h>
#include <media/v4l2-dv-timings.h>
#include <media/v4l2-ioctl.h>
@@ -703,6 +704,17 @@ static void vivid_thread_vid_cap_tick(struct vivid_dev *dev, int dropped_bufs)
goto update_mv;
if (vid_cap_buf) {
+ struct media_request *req = vid_cap_buf->vb.vb2_buf.request;
+
+ /* Using request? Apply its controls */
+ if (req) {
+ struct v4l2_request_entity_data *data;
+ data = to_v4l2_entity_data(
+ media_request_get_entity_data(req,
+ &dev->vid_cap_req_entity.base));
+ if (!WARN_ON(IS_ERR(data)))
+ v4l2_ctrl_request_setup(&data->ctrls);
+ }
/* Fill buffer */
vivid_fillbuff(dev, vid_cap_buf);
dprintk(dev, 1, "filled buffer %d\n",
@@ -717,6 +729,11 @@ static void vivid_thread_vid_cap_tick(struct vivid_dev *dev, int dropped_bufs)
VB2_BUF_STATE_ERROR : VB2_BUF_STATE_DONE);
dprintk(dev, 2, "vid_cap buffer %d done\n",
vid_cap_buf->vb.vb2_buf.index);
+ if (req)
+ media_request_entity_complete(req,
+ &dev->vid_cap_req_entity.base);
+ dprintk(dev, 2, "vid_cap buffer %d request completed\n",
+ vid_cap_buf->vb.vb2_buf.index);
}
if (vbi_cap_buf) {
--
2.16.1.291.g4437f3f132-goog
next prev parent reply other threads:[~2018-02-20 4:46 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 4:44 [RFCv4 00/21] Request API Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 01/21] media: add request API core and UAPI Alexandre Courbot
2018-02-20 10:36 ` Hans Verkuil
2018-02-21 6:01 ` Alexandre Courbot
2018-02-21 7:29 ` Hans Verkuil
2018-02-22 9:30 ` Alexandre Courbot
2018-02-22 9:38 ` Hans Verkuil
2018-02-20 4:44 ` [RFCv4 02/21] v4l2-ctrls: v4l2_ctrl_add_handler: add from_other_dev Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 03/21] v4l2-ctrls: prepare internal structs for request API Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 04/21] v4l2-ctrls: add core " Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 05/21] v4l2-ctrls: use ref in helper instead of ctrl Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 06/21] v4l2-ctrls: support g/s_ext_ctrls for requests Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 07/21] v4l2-ctrls: add v4l2_ctrl_request_setup Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 08/21] [WAR] v4l2-ctrls: do not clone non-standard controls Alexandre Courbot
2018-02-20 13:05 ` Hans Verkuil
2018-02-20 4:44 ` [RFCv4 09/21] v4l2: add request API support Alexandre Courbot
2018-02-20 7:36 ` Philippe Ombredanne
2018-02-20 8:03 ` Alexandre Courbot
2018-02-20 13:25 ` Hans Verkuil
2018-02-21 6:01 ` Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 10/21] videodev2.h: Add request_fd field to v4l2_buffer Alexandre Courbot
2018-02-20 15:20 ` Hans Verkuil
2018-02-21 6:01 ` Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 11/21] media: v4l2_fh: add request entity field Alexandre Courbot
2018-02-20 15:24 ` Hans Verkuil
2018-02-21 6:01 ` Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 12/21] media: videobuf2: add support for requests Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 13/21] media: videobuf2-v4l2: " Alexandre Courbot
2018-02-20 16:18 ` Hans Verkuil
2018-02-21 6:01 ` Alexandre Courbot
2018-02-23 6:34 ` Tomasz Figa
2018-02-23 7:21 ` Hans Verkuil
2018-02-23 7:33 ` Tomasz Figa
2018-02-23 7:43 ` Hans Verkuil
2018-03-07 16:50 ` [RFCv4,13/21] " Paul Kocialkowski
2018-03-08 13:50 ` Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 14/21] videodev2.h: add request_fd field to v4l2_ext_controls Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 15/21] v4l2-ctrls: support requests in EXT_CTRLS ioctls Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 16/21] v4l2: video_device: support for creating requests Alexandre Courbot
2018-02-20 16:35 ` Hans Verkuil
2018-02-21 6:01 ` Alexandre Courbot
2018-02-21 7:37 ` Hans Verkuil
2018-02-20 4:44 ` [RFCv4 17/21] media: mem2mem: support for requests Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 18/21] Documentation: v4l: document request API Alexandre Courbot
2018-02-20 4:44 ` [RFCv4 19/21] media: vim2m: add request support Alexandre Courbot
2018-03-07 16:37 ` [RFCv4,19/21] " Paul Kocialkowski
2018-03-08 13:48 ` Alexandre Courbot
2018-03-09 14:35 ` Paul Kocialkowski
2018-03-13 10:24 ` Alexandre Courbot
2018-03-14 13:25 ` Paul Kocialkowski
2018-03-19 9:17 ` Alexandre Courbot
2018-03-11 19:40 ` Dmitry Osipenko
2018-03-11 19:42 ` Dmitry Osipenko
2018-03-12 8:10 ` Paul Kocialkowski
2018-03-12 8:15 ` Tomasz Figa
2018-03-12 8:25 ` Paul Kocialkowski
2018-03-12 8:29 ` Tomasz Figa
2018-03-12 12:21 ` Dmitry Osipenko
2018-03-12 12:32 ` Alexandre Courbot
2018-03-12 14:44 ` Dmitry Osipenko
2018-02-20 4:44 ` Alexandre Courbot [this message]
2018-02-20 4:44 ` [RFCv4 21/21] [WIP] media: media-device: support for creating requests Alexandre Courbot
2018-02-20 4:54 ` [RFCv4 00/21] Request API Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220044425.169493-21-acourbot@chromium.org \
--to=acourbot@chromium.org \
--cc=gustavo.padovan@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=posciak@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).