From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751391AbeBTKIB (ORCPT ); Tue, 20 Feb 2018 05:08:01 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:33717 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbeBTKH6 (ORCPT ); Tue, 20 Feb 2018 05:07:58 -0500 X-Google-Smtp-Source: AH8x224gOw7LwZNjRynDRqgkTLYXfHwqbKKTptM2SeVGsKcMjZavyapLbDO65xSFgBnbocsd1Xq8xQ== Date: Tue, 20 Feb 2018 11:07:55 +0100 From: Thierry Reding To: Randy Dunlap Cc: Stephen Rothwell , Linux-Next Mailing List , Linux Kernel Mailing List , Eric Anholt , dri-devel Subject: Re: linux-next: Tree for Feb 19 (gpu/drm/pl111/) Message-ID: <20180220100755.GG23425@ulmo> References: <20180219131426.14ecac87@canb.auug.org.au> <5a671632-f746-52d2-1a9c-1e72a7e2f42b@infradead.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/Zw+/jwnNHcBRYYu" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/Zw+/jwnNHcBRYYu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 19, 2018 at 10:30:06AM -0800, Randy Dunlap wrote: > [add Eric + dri-devel] >=20 > On 02/19/18 09:26, Randy Dunlap wrote: > > On 02/18/18 18:14, Stephen Rothwell wrote: > >> Hi all, > >> > >> Changes since 20180216: > >> > >> The nand tree gained a conflict against Linus' tree. > >> > >> The drm tree gained conflicts against Linus' tree. > >=20 > > on i386 (randconfig): > >=20 > > warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct de= pendencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) I think this is caused by the fact that DRM_PL111 has || COMPILE_TEST in the architecture dependencies, which causes it to be unavailable on systems other than ARM and ARM64 where OF may not be implied. Then the DRM_PL111 selects DRM_DUMB_VGA_DAC that has a dependency on OF. I think the best solution would be to remove the select DRM_DUMB_VGA_DAC =66rom DRM_PL111. Also see the warning against selecting visible symbols in Documentation/kbuild/kconfig-language.txt (line 127). > > and then > >=20 > > ../drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': > > ../drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bri= dge' has no member named 'of_node' > > vga->bridge.of_node =3D pdev->dev.of_node; > > ^ Irrespective of the above, I don't think it's very useful to have of_node conditionally included in this structure. This used to be the case for struct gpio_chip (and others) and used to cause lots of such build failures because people tend not to build-test OF vs. !OF Thierry --/Zw+/jwnNHcBRYYu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlqL83gACgkQ3SOs138+ s6HwkA/9Er6eoWKkfjrFSIO6yZITLmunvFv7Y8KWURJI7ty7D846CxhnTIchcAGL WHRt4/yvxwez1BbfcPCtwVBzF39v3LXtA9qOhONvDP76MC6kiWrA32IRC7jey6yP kpGe5/XsIJzJu+e+M2qPAkzOyiSjobTuR6vIvDVKxOM2oM1lcxckcU/p/CknOFvG RsIQxA0C478iM8rbMp8e095S1O4ESDsUeV5YogqNsx8JYLR9e0Mxzd3pW2YXnBLB KThQA3cQJsiuPfSw6K3eSLRMkgRwlKPaLY0qnHyh7cGFP4p3GeK15gl0Zwazxf+U bJg4P0nS0cisw8ZVg9KRyFEp8JV1Bpl8ZoYMnkgsNGhoiOjXmdSfAqTrSKX+N3AL BemAxPlA9loDeoBt4zYIrlW3HPuykgBqZQC9q140E/EDTFeXTEfa9zRoQGv3or0Y I2YIgqamWrAq16va/OeFUv6MpUF6XwbAh59ihY2gCrHghTNybnTPp6Yy08zpayot yviQInfL+A9xOtxc/OzgErp6EN45b17VGdFjan7o+F00XS545TAWcunADKAhzDuP 7IzkT/TDWwxRuye6X/apkbUEy6NDlfSx7cHvIpDzCAtsv2iso7kp8PR/TWMaOHah RlqbI6ap5je73mLSupw6HYdWqp/PvPT8Iz1PLB1o0NpODFlgYjU= =p7zH -----END PGP SIGNATURE----- --/Zw+/jwnNHcBRYYu--