From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
daniel.baluta@nxp.com, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments
Date: Tue, 20 Feb 2018 15:36:52 +0300 [thread overview]
Message-ID: <20180220123652.evmvebkdimfcofl3@mwanda> (raw)
In-Reply-To: <20180220122156.s25laa4wgcf3hxuz@smtp.gmail.com>
On Tue, Feb 20, 2018 at 09:21:56AM -0300, Rodrigo Siqueira wrote:
> On 02/20, Dan Carpenter wrote:
> > > On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote:
> > ^^^^^^^^^^^^^^^
> > This looks good, but you need to fix your from email header.
>
> Thanks for the review, and the feedback related to the email header.
> I already fixed it. Is it necessary to resend the patch?
>
I don't know? Sometimes mainainters will cleanup patches themselves...
Probably it's simplest to just resend, yes.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-02-20 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 16:28 [PATCH v2] staging:iio:meter: Add name to function definition arguments rodrigosiqueira
2018-02-20 7:24 ` Dan Carpenter
2018-02-20 12:21 ` Rodrigo Siqueira
2018-02-20 12:36 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220123652.evmvebkdimfcofl3@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox