From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752771AbeBTQK5 (ORCPT ); Tue, 20 Feb 2018 11:10:57 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46264 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbeBTQK4 (ORCPT ); Tue, 20 Feb 2018 11:10:56 -0500 Date: Tue, 20 Feb 2018 08:11:10 -0800 From: "Paul E. McKenney" To: Andrea Parri Cc: Peter Zijlstra , Alan Stern , Akira Yokosawa , Kernel development list , mingo@kernel.org, Will Deacon , boqun.feng@gmail.com, npiggin@gmail.com, dhowells@redhat.com, Jade Alglave , Luc Maranget , Patrick Bellasi Subject: Re: [PATCH] tools/memory-model: remove rb-dep, smp_read_barrier_depends, and lockless_dereference Reply-To: paulmck@linux.vnet.ibm.com References: <20180217151413.GA3785@andrea> <20180219174413.GV25201@hirez.programming.kicks-ass.net> <20180220144813.GF3617@linux.vnet.ibm.com> <20180220151752.GA1900@andrea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180220151752.GA1900@andrea> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18022016-0052-0000-0000-000002BB3856 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008564; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000254; SDB=6.00992540; UDB=6.00504256; IPR=6.00771886; MB=3.00019657; MTD=3.00000008; XFM=3.00000015; UTC=2018-02-20 16:10:51 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18022016-0053-0000-0000-00005BC15ACF Message-Id: <20180220161110.GK3617@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-20_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802200200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 20, 2018 at 04:17:52PM +0100, Andrea Parri wrote: > On Tue, Feb 20, 2018 at 06:48:13AM -0800, Paul E. McKenney wrote: > > On Mon, Feb 19, 2018 at 06:44:13PM +0100, Peter Zijlstra wrote: > > > On Mon, Feb 19, 2018 at 12:14:45PM -0500, Alan Stern wrote: > > > > Note that operations like atomic_add_unless() already include memory > > > > barriers. > > > > > > It is valid for atomic_add_unless() to not imply any barriers when the > > > addition doesn't happen. > > > > Agreed, given that atomic_add_unless() just returns 0 or 1, not the > > pointer being added. Of course, the __atomic_add_unless() function > > that it calls is another story, as it does return the old value. Sigh. > > And __atomic_add_unless() is called directly from some code. All of > > which looks to be counters rather than pointers, thankfully. > > > > So, do we want to rely on atomic_add_unless() always being > > invoked on counters rather than pointers, or does it need an > > smp_read_barrier_depends()? > > alpha's implementation of __atomic_add_unless() has an unconditional smp_mb() > before returning so, as far as dependencies are concerned, these seem fine. Very good! Thanx, Paul