public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] libata: disable LPM for Crucial BX100 SSD 500GB drive
@ 2018-02-18 14:17 Kai-Heng Feng
  2018-02-20 21:31 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Kai-Heng Feng @ 2018-02-18 14:17 UTC (permalink / raw)
  To: tj; +Cc: hdegoede, linux-ide, linux-kernel, Kai-Heng Feng

After Laptop Mode Tools starts to use min_power for LPM, a user found
out Crucial BX100 SSD can't get mounted.

Crucial BX100 SSD 500GB drive don't work well with min_power. This also
happens to med_power_with_dipm.

So let's disable LPM for Crucial BX100 SSD 500GB drive.

BugLink: https://bugs.launchpad.net/bugs/1726930
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v2: Only apply the quirk to 500GB variant with firmware version MU02,
also reorder the quirk entry to make it next to other Crucial disks.

 drivers/ata/libata-core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 28cad49fc846..cb789f8849ae 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4530,6 +4530,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "PIONEER DVD-RW  DVR-212D",	NULL,	ATA_HORKAGE_NOSETXFER },
 	{ "PIONEER DVD-RW  DVR-216D",	NULL,	ATA_HORKAGE_NOSETXFER },
 
+	/* Crucial BX100 SSD 500GB has broken LPM support */
+	{ "CT500BX100SSD1",		"MU02",	ATA_HORKAGE_NOLPM },
+
 	/* The 512GB version of the MX100 has both queued TRIM and LPM issues */
 	{ "Crucial_CT512MX100*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
 						ATA_HORKAGE_ZERO_AFTER_TRIM |
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] libata: disable LPM for Crucial BX100 SSD 500GB drive
  2018-02-18 14:17 [PATCH v2] libata: disable LPM for Crucial BX100 SSD 500GB drive Kai-Heng Feng
@ 2018-02-20 21:31 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2018-02-20 21:31 UTC (permalink / raw)
  To: Kai-Heng Feng; +Cc: hdegoede, linux-ide, linux-kernel

On Sun, Feb 18, 2018 at 10:17:09PM +0800, Kai-Heng Feng wrote:
> After Laptop Mode Tools starts to use min_power for LPM, a user found
> out Crucial BX100 SSD can't get mounted.
> 
> Crucial BX100 SSD 500GB drive don't work well with min_power. This also
> happens to med_power_with_dipm.
> 
> So let's disable LPM for Crucial BX100 SSD 500GB drive.
> 
> BugLink: https://bugs.launchpad.net/bugs/1726930
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Applied to libata/for-4.16-fixes.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-20 21:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-18 14:17 [PATCH v2] libata: disable LPM for Crucial BX100 SSD 500GB drive Kai-Heng Feng
2018-02-20 21:31 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox