From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227ZmsT+tZYcLGejPJkMuLQa9Dszc7qv6YZbh8+Me6JjeCtk5rzt0bO/WiUxeNWyAsYN/DCZ ARC-Seal: i=1; a=rsa-sha256; t=1519218160; cv=none; d=google.com; s=arc-20160816; b=bzdD44lXnFw1bkeeLpca7HeFhBL3QDPhF6Kf6Uqj0Mim81bVXCB+QkwyteCRvHIyhI nyNbNIjpci/DrDSTi8Ncc2NGOeBI0rozfz6Oj3jDl7MJ/+fgE3ak/y7EPckGnKvzX6w0 DWu0PqF0pMRyJdinzB+MSn+Ux2tVurnPQy1adnXQXFi/M8cD1XEc13y9OwCZHbtoAacf iIeVgJ6rdFyw9jJjaquxS7IS/uX2HtCjmdaig/T5lJ+r1IrxD6tZOsFNRN+2hYJa6UOF 8YVwICioQti/FYgOtqMObvskr5cZ+inYH9a0uwmiVFFPMORudsdXc4zwbFhi/BViB09n 4luQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=1l7Op4mP7uSFi1e45VVkBfw/ICHXLackO58zSk13O08=; b=PcfK6NPipclWVErPZZHJURdwL2dsiTcDzQuSRZiWcMyXhOo19HC5VodIvgK/m8FKmk KGOyLIQFBAukYQ4pNjjFtbjXqAl4kHWEU/sAC5Btd5Nj9iu2zUXRgdngNt0TJVPL5I1f BmiiYj0LHuGHcDaf3TTB65AZWcPlzBnK2lCoUN+oAPtGIG4PhRZP99YXSlUjg0px/sXE K3az+bjKpwkmF/4r1d6NfnEZbGdrU3QFfBjIxR2eJEZjvY5LY4kJQGsVBWasnidnt2Qm Om6o//rRjsNQ4231VRsPy5RT5a/JAhH/tQ8WseXtxGgLUBumyZdRpJBrurQDFCp2pdNZ 7quA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Borislav Petkov , Josh Poimboeuf , "Peter Zijlstra (Intel)" , Andy Lutomirski , Arjan van de Ven , Brian Gerst , Denys Vlasenko , "H. Peter Anvin" , Linus Torvalds , Thomas Gleixner , kbuild test robot , Ingo Molnar Subject: [PATCH 4.14 074/167] x86/debug, objtool: Annotate WARN()-related UD2 as reachable Date: Wed, 21 Feb 2018 13:48:05 +0100 Message-Id: <20180221124528.538238500@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180221124524.639039577@linuxfoundation.org> References: <20180221124524.639039577@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1593015701695663855?= X-GMAIL-MSGID: =?utf-8?q?1593015701695663855?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josh Poimboeuf commit 2b5db66862b95532cb6cca8165ae6eb73633cf85 upstream. By default, objtool assumes that a UD2 is a dead end. This is mainly because GCC 7+ sometimes inserts a UD2 when it detects a divide-by-zero condition. Now that WARN() is moving back to UD2, annotate the code after it as reachable so objtool can follow the code flow. Reported-by: Borislav Petkov Signed-off-by: Josh Poimboeuf Signed-off-by: Peter Zijlstra (Intel) Cc: Andy Lutomirski Cc: Arjan van de Ven Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: kbuild test robot Link: http://lkml.kernel.org/r/0e483379275a42626ba8898117f918e1bf661e40.1518130694.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/bug.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/arch/x86/include/asm/bug.h +++ b/arch/x86/include/asm/bug.h @@ -77,7 +77,11 @@ do { \ unreachable(); \ } while (0) -#define __WARN_FLAGS(flags) _BUG_FLAGS(ASM_UD0, BUGFLAG_WARNING|(flags)) +#define __WARN_FLAGS(flags) \ +do { \ + _BUG_FLAGS(ASM_UD0, BUGFLAG_WARNING|(flags)); \ + annotate_reachable(); \ +} while (0) #include