From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224I7D8KCi/wwDCaWLOYbSvEmQSqtkL1xPj7P/qFpoIIbHS67BERlfoONM5c9D/Awq3AJ0Sl ARC-Seal: i=1; a=rsa-sha256; t=1519218250; cv=none; d=google.com; s=arc-20160816; b=Gp1GM5IvXSyaKOCEf1QN7uSrODZTaRTAT04Bl+Og9wFTNKqRI7Nh019F2MRizER1WZ 8nBEirMwuG/1zDGc6Qmcsp0g7dfdk4F5L621+19T6OKynueQnFBRgheHwl53UrrCqgXp FD5dPiiqjewTN/gwSQ4K2tdcnZ9MtpaxMzaJ4ntN37oGQ2N6VI748RGy8fdyEVtwA3lt HuuDos7csAdYkM9lRnxM5YZIHEk2IQs4XjmlrkCSpXNFpxVQUdMbtFBqtzQCZtPwtj4h V/ptfRPPcgLGVJuWgb3QB28WwQluJqW0AjYfsNK88dsLqmMgtOvXZjDLuD2k1aFBvz00 0u8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=2U5Mx3yW1cZ8/+YgYV8C4frdMaNwAF0VKiNbxvyVrKs=; b=fGifrHWMv7lZRqf0MbID5liiNBqlOFNPGOXB515WKs3+IJdUy+ADGTubM+kISE3RUq q9RdpvkzN8NRX70Cny5jUtB/slfc2k6YR/ypN90o3D6oX6iWBomzUwLcM/ejETW9Arqe VemsK9/FSd2imGlOxEB6YOxclra6jnRX6GC1Uln6kD74xE50Txv2kWyEa2X0OpdlJagG 1CF4G7oL97sUP9Crf+8RzETpRzYwEFhja2fxmHEmdzK1Q67tscCfPuY8naj5DIaBEI1H dyB5FfmTEJkI7N7aM2GZ6FIhR77U4cpXPoARZZSzg/Gy4od/MIgEG0wLllRkQA0ve9on Gn9w== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liu Bo , Josef Bacik , David Sterba Subject: [PATCH 4.14 139/167] Btrfs: fix unexpected -EEXIST when creating new inode Date: Wed, 21 Feb 2018 13:49:10 +0100 Message-Id: <20180221124532.304159380@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180221124524.639039577@linuxfoundation.org> References: <20180221124524.639039577@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1593014643316551271?= X-GMAIL-MSGID: =?utf-8?q?1593015796728844096?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Liu Bo commit 900c9981680067573671ecc5cbfa7c5770be3a40 upstream. The highest objectid, which is assigned to new inode, is decided at the time of initializing fs roots. However, in cases where log replay gets processed, the btree which fs root owns might be changed, so we have to search it again for the highest objectid, otherwise creating new inode would end up with -EEXIST. cc: v4.4-rc6+ Fixes: f32e48e92596 ("Btrfs: Initialize btrfs_root->highest_objectid when loading tree root and subvolume roots") Signed-off-by: Liu Bo Reviewed-by: Josef Bacik Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/tree-log.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -28,6 +28,7 @@ #include "hash.h" #include "compression.h" #include "qgroup.h" +#include "inode-map.h" /* magic values for the inode_only field in btrfs_log_inode: * @@ -5715,6 +5716,23 @@ again: path); } + if (!ret && wc.stage == LOG_WALK_REPLAY_ALL) { + struct btrfs_root *root = wc.replay_dest; + + btrfs_release_path(path); + + /* + * We have just replayed everything, and the highest + * objectid of fs roots probably has changed in case + * some inode_item's got replayed. + * + * root->objectid_mutex is not acquired as log replay + * could only happen during mount. + */ + ret = btrfs_find_highest_objectid(root, + &root->highest_objectid); + } + key.offset = found_key.offset - 1; wc.replay_dest->log_root = NULL; free_extent_buffer(log->node);