From: Theodore Ts'o <tytso@mit.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Tommi Rantala <tommi.t.rantala@nokia.com>,
Tahsin Erdogan <tahsin@google.com>,
Andreas Dilger <adilger@dilger.ca>,
linux-ext4@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: backporting "ext4: inplace xattr block update fails to deduplicate blocks" to LTS kernels?
Date: Wed, 21 Feb 2018 10:56:45 -0500 [thread overview]
Message-ID: <20180221155644.GC9900@thunk.org> (raw)
In-Reply-To: <20180221114000.GB6555@kroah.com>
On Wed, Feb 21, 2018 at 12:40:00PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 19, 2018 at 03:26:37PM +0200, Tommi Rantala wrote:
> >
> > OK to backport it?
> > I tested it briefly in 4.9, seems to work.
It looks sane, but it would be nice if I can get people who are
backporting ext4 patches to make sure there are no regressions using
one of kvm-xfstests[1] or gce-xfstests[2][3].....
[1] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-xfstests.md
[2] https://github.com/tytso/xfstests-bld/blob/master/Documentation/gce-xfstests.md
[3] https://thunk.org/gce-xfstests
I do run regression tests[4] on stable kernels when I have time, but
it scales much better when other people can help.
[4] https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/tag/?h=ext4-4.9.54-1
> I need an ack from the ext4 maintainers before I can take this...
Greg, you can go ahead and take this, but in the future I'd appreciate
it if ext4 backporters could at least run a smoke test (which takes
less than 15 minutes on GCE) before and after the patch, and report no
test regressions.
More aggressive testers can and should run "{kvm,gce}-xfstests auto"
which take overnight, and the really adventurous can use the
lightweight test manager (ltm) which will break up the test run the
job across multiple VM's and do the job in about 2.5 hours or so. :-)
- Ted
next prev parent reply other threads:[~2018-02-21 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 13:26 backporting "ext4: inplace xattr block update fails to deduplicate blocks" to LTS kernels? Tommi Rantala
2018-02-21 11:40 ` Greg Kroah-Hartman
2018-02-21 15:56 ` Theodore Ts'o [this message]
2018-02-22 13:37 ` Tommi Rantala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221155644.GC9900@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tahsin@google.com \
--cc=tommi.t.rantala@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox