From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, avagin@virtuozzo.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2] proc: fix /proc/*/map_files lookup some more
Date: Wed, 21 Feb 2018 23:29:11 +0300 [thread overview]
Message-ID: <20180221202911.GC2092@uranus.lan> (raw)
In-Reply-To: <20180221120403.504b7f1c814618bac39bb78b@linux-foundation.org>
On Wed, Feb 21, 2018 at 12:04:03PM -0800, Andrew Morton wrote:
>
> I don't know this code and I'm all confused.
>
> - why is the code designed to accept addresses of "0"?
It was never designed to accept addresses of 0, it is rather
a side effect of using sscanf in first place.
The address priting is done via
len = snprintf(buf, sizeof(buf), "%lx-%lx", p->start, p->end);
> - how do we know that the first digit of a VMA address will never be 0?
It should not be, due to snprintf above.
---
Thanks a lot, Alexey!
Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
next prev parent reply other threads:[~2018-02-21 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 18:44 [PATCH] proc: fix /proc/*/map_files lookup some more Alexey Dobriyan
2018-02-21 18:51 ` Al Viro
2018-02-21 19:53 ` [PATCH v2] " Alexey Dobriyan
2018-02-21 20:04 ` Andrew Morton
2018-02-21 20:29 ` Cyrill Gorcunov [this message]
2018-02-21 20:58 ` Alexey Dobriyan
-- strict thread matches above, loose matches on Subject: below --
2018-03-03 21:51 Alexey Dobriyan
2018-03-04 20:53 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221202911.GC2092@uranus.lan \
--to=gorcunov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).