* [PATCH] pcf85063 was not clearing bits correctly in pcf85063_start_clock
@ 2018-02-21 22:29 Michael McCormick
2018-03-13 0:41 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Michael McCormick @ 2018-02-21 22:29 UTC (permalink / raw)
To: a.zummo; +Cc: alexandre.belloni, linux-rtc, linux-kernel, michael.mccormick
Bit clear operation was missing ~
Signed-off-by: Michael McCormick <michael.mccormick@enatel.net>
---
drivers/rtc/rtc-pcf85063.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
index a06dff9..67bc763 100644
--- a/drivers/rtc/rtc-pcf85063.c
+++ b/drivers/rtc/rtc-pcf85063.c
@@ -70,7 +70,7 @@ static int pcf85063_start_clock(struct i2c_client *client, u8 ctrl1)
s32 ret;
/* start the clock */
- ctrl1 &= PCF85063_REG_CTRL1_STOP;
+ ctrl1 &= ~PCF85063_REG_CTRL1_STOP;
ret = i2c_smbus_write_byte_data(client, PCF85063_REG_CTRL1, ctrl1);
if (ret < 0) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pcf85063 was not clearing bits correctly in pcf85063_start_clock
2018-02-21 22:29 [PATCH] pcf85063 was not clearing bits correctly in pcf85063_start_clock Michael McCormick
@ 2018-03-13 0:41 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2018-03-13 0:41 UTC (permalink / raw)
To: Michael McCormick; +Cc: a.zummo, linux-rtc, linux-kernel
On 22/02/2018 at 11:29:24 +1300, Michael McCormick wrote:
> Bit clear operation was missing ~
>
> Signed-off-by: Michael McCormick <michael.mccormick@enatel.net>
> ---
> drivers/rtc/rtc-pcf85063.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-13 0:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-21 22:29 [PATCH] pcf85063 was not clearing bits correctly in pcf85063_start_clock Michael McCormick
2018-03-13 0:41 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).