From: Kees Cook <keescook@chromium.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-doc@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
Joe Perches <joe@perches.com>
Subject: [PATCH] doc: process: Add "Root-caused-by" and "Suggested-by"
Date: Wed, 21 Feb 2018 16:37:50 -0800 [thread overview]
Message-ID: <20180222003749.GA4724@beast> (raw)
As recently pointed out by Linus, "Root-caused-by" is a good tag to include
since it can indicate significantly more work than "just" a Reported-by.
This adds it and "Suggested-by" (which was also missing) to the documented
list of tags. Additionally updates checkpatch.pl to match the process docs.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
Documentation/process/5.Posting.rst | 7 +++++++
scripts/checkpatch.pl | 2 ++
2 files changed, 9 insertions(+)
diff --git a/Documentation/process/5.Posting.rst b/Documentation/process/5.Posting.rst
index 645fa9c7388a..2ff01f76f02a 100644
--- a/Documentation/process/5.Posting.rst
+++ b/Documentation/process/5.Posting.rst
@@ -234,6 +234,13 @@ The tags in common use are:
people who test our code and let us know when things do not work
correctly.
+ - Suggested-by: names a person who suggested the solution, but may not
+ have constructed the full patch. A weaker version of `Co-Developed-by`.
+
+ - Root-caused-by: names a person who diagnosed the root cause of a
+ problem. This usually indicates significantly more work than a simple
+ `Reported-by`.
+
- Cc: the named person received a copy of the patch and had the
opportunity to comment on it.
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3d4040322ae1..a1ab82e70b54 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -464,9 +464,11 @@ our $logFunctions = qr{(?x:
our $signature_tags = qr{(?xi:
Signed-off-by:|
Acked-by:|
+ Co-Developed-by:|
Tested-by:|
Reviewed-by:|
Reported-by:|
+ Root-caused-by:|
Suggested-by:|
To:|
Cc:
--
2.7.4
--
Kees Cook
Pixel Security
next reply other threads:[~2018-02-22 0:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 0:37 Kees Cook [this message]
2018-02-22 2:13 ` [PATCH] doc: process: Add "Root-caused-by" and "Suggested-by" Joe Perches
2018-02-22 2:16 ` Kees Cook
2018-02-22 4:43 ` Randy Dunlap
2018-02-22 6:03 ` Kees Cook
2018-02-22 17:29 ` Randy Dunlap
2018-02-22 17:40 ` Jonathan Corbet
2018-02-22 23:52 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222003749.GA4724@beast \
--to=keescook@chromium.org \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox