From: Darren Hart <dvhart@infradead.org>
To: Jeremy Cline <jeremy@jcline.org>
Cc: Mario Limonciello <mario.limonciello@dell.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Alex Hung <alex.hung@canonical.com>
Subject: Re: [PATCH] platform/x86: Only activate tablet mode switch on 2-in-1's
Date: Thu, 22 Feb 2018 12:21:40 -0800 [thread overview]
Message-ID: <20180222202140.GF19843@fury> (raw)
In-Reply-To: <01000161bf28670e-bfeaa576-853c-4760-a362-d6abdaa474f1-000000@email.amazonses.com>
On Thu, Feb 22, 2018 at 08:15:51PM +0000, Jeremy Cline wrote:
> On Thu, Feb 22, 2018 at 01:58:42PM -0600, Mario Limonciello wrote:
> > Some laptops such as the XPS 9360 support the intel-vbtn INT33D6
> > interface but don't initialize the bit that intel-vbtn uses to
> > represent switching tablet mode.
> >
> > By running this only on real 2-in-1's it shouldn't cause false
> > positives.
> >
> > Fixes: 30323fb6d5 ("Support tablet mode switch")
> > Reported-by: Jeremy Cline <jeremy@jcline.org>
> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > ---
> > Note: I also moved the code for detecting tablet into it's own
> > function. To keep things under 80 lines with if statements was
> > making the code very unreadable otherwise.
> >
...
>
> Tested-by: Jeremy Cline <jeremy@jcline.org>
Wow, incredible turn around time Mario and Jeremy. Doing some
confirmation on my end, and will queue up to Fixes for 4.16 RC cycle.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-02-22 20:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 19:58 [PATCH] platform/x86: Only activate tablet mode switch on 2-in-1's Mario Limonciello
2018-02-22 20:15 ` Jeremy Cline
2018-02-22 20:21 ` Darren Hart [this message]
2018-02-22 20:46 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222202140.GF19843@fury \
--to=dvhart@infradead.org \
--cc=alex.hung@canonical.com \
--cc=andy.shevchenko@gmail.com \
--cc=jeremy@jcline.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox