From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-gpio@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency"
Date: Fri, 23 Feb 2018 10:25:53 -0500 [thread overview]
Message-ID: <20180223152553.GA20248@sophia> (raw)
In-Reply-To: <CAK8P3a3-NTzY3x5xM_d8Bxm-s+SF0L8d60vd-FOHccVxXo_AVg@mail.gmail.com>
On Fri, Feb 23, 2018 at 04:19:01PM +0100, Arnd Bergmann wrote:
>On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero
><mail@maciej.szmigiero.name> wrote:
>> This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72.
>>
>> Now that the patch series changing ISA_BUS_API dependency to selection
>> was merged this reversion will do the same for gpio-winbond driver to
>> make it consistent with other ISA bus gpio drivers.
>>
>> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
>
>I still see a number of other users of 'depends on ISA_BUS_API' in linux-next:
>
>drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig: depends on ISA_BUS_API
>drivers/gpio/Kconfig: depends on ISA_BUS_API
>drivers/iio/adc/Kconfig: depends on PC104 && X86 && ISA_BUS_API
>drivers/iio/counter/Kconfig: depends on PC104 && X86 && ISA_BUS_API
>drivers/iio/dac/Kconfig: depends on X86 && ISA_BUS_API
>drivers/watchdog/Kconfig: depends on X86 && ISA_BUS_API
>
>Did you change all of the above? I would really like to avoid mixing
>'select' and 'depends on' here, as that will likely cause other circular
>dependencies in the future.
>
> Arnd
Those 'depends on' for ISA_BUS_API are resolved in the devel branch of
the linux-gpio tree; this revert patch should be applied there before
being picked up later for linux-next.
William Breathitt Gray
next prev parent reply other threads:[~2018-02-23 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 14:55 [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency" Maciej S. Szmigiero
2018-02-23 15:19 ` Arnd Bergmann
2018-02-23 15:20 ` Andy Shevchenko
2018-02-23 15:25 ` William Breathitt Gray [this message]
2018-02-26 10:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223152553.GA20248@sophia \
--to=vilhelm.gray@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mail@maciej.szmigiero.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox