From: Pavel Machek <pavel@ucw.cz>
To: Florian Vaussard <florian.vaussard@gmail.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation
Date: Sat, 24 Feb 2018 09:52:56 +0100 [thread overview]
Message-ID: <20180224085256.GC12996@amd> (raw)
In-Reply-To: <20180221214654.3306-2-florian.vaussard@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
Hi!
> +Required properties:
> + - compatible: Should be "onnn,ncp5623"
> + - reg: I2C slave address (fixed to 0x38)
..
> +Required properties:
> + - reg : LED channel number (0..2)
For consistency, there should be no space between reg and :.
Anyway, this can be fixed later.
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-02-24 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 21:46 [PATCH v4 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver Florian Vaussard
2018-02-21 21:46 ` [PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation Florian Vaussard
2018-02-24 8:52 ` Pavel Machek [this message]
2018-02-25 14:30 ` Jacek Anaszewski
2018-02-21 21:46 ` [PATCH v4 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver Florian Vaussard
2018-02-21 22:20 ` Andy Shevchenko
2018-02-24 8:53 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224085256.GC12996@amd \
--to=pavel@ucw.cz \
--cc=florian.vaussard@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox