From: "Tobin C. Harding" <me@tobin.cc>
To: Tycho Andersen <tycho@tycho.ws>
Cc: Kernel Hardening <kernel-hardening@lists.openwall.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] leaking_addresses: add scan_once array
Date: Mon, 26 Feb 2018 13:01:32 +1100 [thread overview]
Message-ID: <20180226020132.GF2808@eros> (raw)
In-Reply-To: <20180226010953.37z3sz3rwcnj426k@cisco>
On Sun, Feb 25, 2018 at 06:09:53PM -0700, Tycho Andersen wrote:
> Hi Tobin,
>
> On Mon, Feb 19, 2018 at 01:50:49PM +1100, Tobin C. Harding wrote:
> > +sub already_scanned
> > +{
> > + my ($filename) = @_;
> > + state %seen;
> > +
> > + foreach (@once_only) {
> > + if (/^$filename$/) {
> > + if ($seen{$_} == 1) {
>
> This should be something like,
>
> if (($seen{$_} //= 0) == 1) {
>
> otherwise I get a bunch of uninitialized warnings,
>
> Use of uninitialized value in pattern match (m//) at /usr/share/perl/5.26/Math/BigInt.pm line 1199.
> Math::BigInt::bcmp(Math::BigInt=HASH(0x55dc2f7e4580), undef) called at /usr/share/perl/5.26/Math/BigInt.pm line 1257
> Math::BigInt::beq(Math::BigInt=HASH(0x55dc2f7e4580), undef) called at /usr/share/perl/5.26/Math/BigInt.pm line 105
> Math::BigInt::__ANON__(Math::BigInt=HASH(0x55dc2f7e4580), undef, 1) called at ./leaking_addresses.pl line 422
> main::already_scanned("smaps") called at ./leaking_addresses.pl line 448
> main::skip("/proc/1/smaps") called at ./leaking_addresses.pl line 509
> main::walk("/proc", "/sys") called at ./leaking_addresses.pl line 159
>
> Tycho
Cool, thanks. Will fix and re-spin.
Tobin
prev parent reply other threads:[~2018-02-26 2:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 2:50 [PATCH 0/4] leaking_addresses: simplify and optimize Tobin C. Harding
2018-02-19 2:50 ` [PATCH 1/4] leaking_addresses: do not parse binary files Tobin C. Harding
2018-02-19 2:50 ` [PATCH 2/4] leaking_addresses: simplify path skipping Tobin C. Harding
2018-02-26 1:26 ` Tycho Andersen
2018-02-26 2:00 ` Tobin C. Harding
2018-02-19 2:50 ` [PATCH 3/4] leaking_addresses: cache architecture name Tobin C. Harding
2018-02-19 2:50 ` [PATCH 4/4] leaking_addresses: add scan_once array Tobin C. Harding
2018-02-26 1:09 ` Tycho Andersen
2018-02-26 2:01 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226020132.GF2808@eros \
--to=me@tobin.cc \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox