From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <yehezkel.bernat@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mario.Limonciello@dell.com,
Radion Mirchevsky <radion.mirchevsky@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Jeremy McNicoll <jmcnicol@redhat.com>,
Andrei Emeltchenko <andrei.emeltchenko@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH v2 07/18] thunderbolt: Handle rejected Thunderbolt devices
Date: Mon, 26 Feb 2018 17:10:37 +0300 [thread overview]
Message-ID: <20180226141048.83949-8-mika.westerberg@linux.intel.com> (raw)
In-Reply-To: <20180226141048.83949-1-mika.westerberg@linux.intel.com>
The ICM firmware may reject devices for different reasons, even if we
have asked it to accept anything. If we notice a device is rejected, we
just log the event and bail out.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/thunderbolt/icm.c | 6 ++++++
drivers/thunderbolt/tb_msgs.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
index 611d28e8e5f2..34d7740d1cbd 100644
--- a/drivers/thunderbolt/icm.c
+++ b/drivers/thunderbolt/icm.c
@@ -410,6 +410,12 @@ icm_fr_device_connected(struct tb *tb, const struct icm_pkg_header *hdr)
ICM_LINK_INFO_DEPTH_SHIFT;
authorized = pkg->link_info & ICM_LINK_INFO_APPROVED;
+ if (pkg->link_info & ICM_LINK_INFO_REJECTED) {
+ tb_info(tb, "switch at %u.%u was rejected by ICM firmware\n",
+ link, depth);
+ return;
+ }
+
ret = icm->get_route(tb, link, depth, &route);
if (ret) {
tb_err(tb, "failed to find route string for switch at %u.%u\n",
diff --git a/drivers/thunderbolt/tb_msgs.h b/drivers/thunderbolt/tb_msgs.h
index b0a092baa605..476bc04cac6c 100644
--- a/drivers/thunderbolt/tb_msgs.h
+++ b/drivers/thunderbolt/tb_msgs.h
@@ -176,6 +176,7 @@ struct icm_fr_event_device_connected {
#define ICM_LINK_INFO_DEPTH_SHIFT 4
#define ICM_LINK_INFO_DEPTH_MASK GENMASK(7, 4)
#define ICM_LINK_INFO_APPROVED BIT(8)
+#define ICM_LINK_INFO_REJECTED BIT(9)
struct icm_fr_pkg_approve_device {
struct icm_pkg_header hdr;
--
2.16.1
next prev parent reply other threads:[~2018-02-26 14:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 14:10 [PATCH v2 00/18] thunderbolt: Add support for Intel Titan Ridge Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 01/18] thunderbolt: Resume control channel after hibernation image is created Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 02/18] thunderbolt: Serialize PCIe tunnel creation with PCI rescan Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 03/18] thunderbolt: Handle connecting device in place of host properly Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 04/18] thunderbolt: Do not overwrite error code when domain adding fails Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 05/18] thunderbolt: Wait a bit longer for root switch config space Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 06/18] thunderbolt: Wait a bit longer for ICM to authenticate the active NVM Mika Westerberg
2018-02-26 14:10 ` Mika Westerberg [this message]
2018-02-26 14:10 ` [PATCH v2 08/18] thunderbolt: Factor common ICM add and update operations out Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 09/18] thunderbolt: Correct function name in kernel-doc comment Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 10/18] thunderbolt: Add tb_switch_get() Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 11/18] thunderbolt: Add tb_switch_find_by_route() Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 12/18] thunderbolt: Add tb_xdomain_find_by_route() Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 13/18] thunderbolt: Add constant for approval timeout Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 14/18] thunderbolt: Move driver ready handling to struct icm Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 15/18] thunderbolt: Add 'boot' attribute for devices Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 16/18] thunderbolt: Add support for preboot ACL Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 17/18] thunderbolt: Introduce USB only (SL4) security level Mika Westerberg
2018-02-26 14:10 ` [PATCH v2 18/18] thunderbolt: Add support for Intel Titan Ridge Mika Westerberg
2018-02-26 15:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226141048.83949-8-mika.westerberg@linux.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=andreas.noever@gmail.com \
--cc=andrei.emeltchenko@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=jmcnicol@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=radion.mirchevsky@intel.com \
--cc=rdunlap@infradead.org \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox