From: Benson Leung <bleung@google.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
lee.jones@linaro.org
Cc: lee.jones@linaro.org, groeck@chromium.org,
andy.shevchenko@gmail.com, kernel@collabora.com,
gwendal@chromium.org, linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Benson Leung <bleung@chromium.org>,
Olof Johansson <olof@lixom.net>,
bleung@google.com
Subject: Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended
Date: Mon, 26 Feb 2018 22:47:32 -0800 [thread overview]
Message-ID: <20180227064732.GB171936@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <20180226102606.15093-4-enric.balletbo@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
Hi Enric,
Thanks for sending this.
On Mon, Feb 26, 2018 at 11:26:01AM +0100, Enric Balletbo i Serra wrote:
> From: Douglas Anderson <dianders@chromium.org>
>
> We should stop our worker thread while we're suspended. If we don't
> then we'll get messages like:
>
> cros-ec-spi spi5.0: spi transfer failed: -108
> cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108
> cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>
> Changes in v3:
> - [3/8] Add Reviewed-by Andy Shevchenko.
>
> Changes in v2:
> - [3/8] That patch is new in this series.
>
> drivers/mfd/cros_ec_dev.c | 4 ++++
> drivers/platform/chrome/cros_ec_debugfs.c | 20 ++++++++++++++++++++
> include/linux/mfd/cros_ec.h | 2 ++
Looks like this will need an immutable branch between mfd and chrome-platform
again, Lee.
Do you want to do one, or should I?
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-27 6:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 10:25 [PATCH v3 0/8] mfd: cros_ec: add subdevices and fixes Enric Balletbo i Serra
2018-02-26 10:25 ` [PATCH v3 1/8] mfd: cros_ec: fail early if we cannot identify the EC Enric Balletbo i Serra
2018-03-07 15:52 ` Lee Jones
2018-02-26 10:26 ` [PATCH v3 2/8] mfd: cros_ec: free IRQ automatically Enric Balletbo i Serra
2018-03-07 15:52 ` Lee Jones
2018-02-26 10:26 ` [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended Enric Balletbo i Serra
2018-02-27 6:47 ` Benson Leung [this message]
2018-03-07 15:53 ` Lee Jones
2018-03-07 15:53 ` Lee Jones
2018-02-26 10:26 ` [PATCH v3 4/8] mfd: cros_ec_dev: Register cros-ec-rtc driver as a subdevice Enric Balletbo i Serra
2018-03-07 15:51 ` Lee Jones
2018-02-26 10:26 ` [PATCH v3 5/8] mfd: cros_ec_dev: Register cros_ec_accel_legacy " Enric Balletbo i Serra
2018-03-07 16:04 ` Lee Jones
2018-03-20 11:37 ` Enric Balletbo Serra
2018-02-26 10:26 ` [PATCH v3 6/8] mfd: cros_ec_dev: register shutdown function for debugfs Enric Balletbo i Serra
2018-03-07 16:05 ` Lee Jones
2018-02-26 10:26 ` [PATCH v3 7/8] mfd: cros_ec_i2c: add ACPI module device table Enric Balletbo i Serra
2018-02-26 11:38 ` Andy Shevchenko
2018-03-07 16:06 ` Lee Jones
2018-02-26 10:26 ` [PATCH v3 8/8] mfd: cros_ec_i2c: moving the system sleep pm ops to late Enric Balletbo i Serra
2018-03-07 16:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227064732.GB171936@decatoncale.mtv.corp.google.com \
--to=bleung@google.com \
--cc=andy.shevchenko@gmail.com \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).