public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Moese <mmoese@suse.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Linux Kernel Mailinglist" <linux-kernel@vger.kernel.org>,
	"Michael Moese" <mmoese@suse.de>,
	"Andreas Geißler" <andreas.geissler@men.de>,
	"Greg KH" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/2] mcb: add Altera PCI ID to mcb-pci
Date: Tue, 27 Feb 2018 14:37:26 +0100	[thread overview]
Message-ID: <20180227133726.frfk2lymnyvrs4th@linux.suse.de> (raw)
In-Reply-To: <20180227133018.7732-3-jthumshirn@suse.de>

Looks good.

Reviewed-by: Michael Moese <mmoese@suse.de>


On Tue, Feb 27, 2018 at 02:30:18PM +0100, Johannes Thumshirn wrote:
> Some older PCI attached MEN FPGAs use an Altera PCI Vendor ID instead
> of the MEN one. Add it to the PCI ID table so the driver automatically
> attaches to it.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Reported-by: Ben Turner <ben.turner@21net.com>
> Tested-by: Ben Turner <ben.turner@21net.com>
> Cc: Andreas Geißler <andreas.geissler@men.de>
> Cc: Michael Moese <mmoese@suse.de>
> ---
>  drivers/mcb/mcb-pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c
> index af4d2f26f1c6..286b32ca526f 100644
> --- a/drivers/mcb/mcb-pci.c
> +++ b/drivers/mcb/mcb-pci.c
> @@ -11,6 +11,7 @@
>  
>  #include <linux/module.h>
>  #include <linux/pci.h>
> +#include <linux/pci_ids.h>
>  #include <linux/mcb.h>
>  
>  #include "mcb-internal.h"
> @@ -117,6 +118,7 @@ static void mcb_pci_remove(struct pci_dev *pdev)
>  
>  static const struct pci_device_id mcb_pci_tbl[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_MEN, PCI_DEVICE_ID_MEN_CHAMELEON) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_ALTERA, PCI_DEVICE_ID_MEN_CHAMELEON) },
>  	{ 0 },
>  };
>  MODULE_DEVICE_TABLE(pci, mcb_pci_tbl);
> -- 
> 2.13.6
> 

-- 
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

  reply	other threads:[~2018-02-27 13:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 13:30 [PATCH 0/2] MCB Update for v4.17 Johannes Thumshirn
2018-02-27 13:30 ` [PATCH 1/2] PCI: add vendor id for Altera Johannes Thumshirn
2018-02-27 15:32   ` Andy Shevchenko
2018-02-27 15:42     ` Johannes Thumshirn
2018-02-27 17:39       ` Bjorn Helgaas
2018-02-27 19:52       ` Eli Billauer
2018-02-27 13:30 ` [PATCH 2/2] mcb: add Altera PCI ID to mcb-pci Johannes Thumshirn
2018-02-27 13:37   ` Michael Moese [this message]
2018-02-27 15:33     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180227133726.frfk2lymnyvrs4th@linux.suse.de \
    --to=mmoese@suse.de \
    --cc=andreas.geissler@men.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox