From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752291AbeB0RHT (ORCPT ); Tue, 27 Feb 2018 12:07:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:47808 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752093AbeB0RHQ (ORCPT ); Tue, 27 Feb 2018 12:07:16 -0500 Date: Tue, 27 Feb 2018 18:06:54 +0100 From: Borislav Petkov To: "Ghannam, Yazen" Cc: "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ard.biesheuvel@linaro.org" , "x86@kernel.org" Subject: Re: [PATCH v2 5/8] efi: Decode IA32/X64 Cache, TLB, and Bus Check structures Message-ID: <20180227170654.GL26382@pd.tnic> References: <20180226193904.20532-1-Yazen.Ghannam@amd.com> <20180226193904.20532-6-Yazen.Ghannam@amd.com> <20180227150356.GH26382@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 27, 2018 at 03:33:44PM +0000, Ghannam, Yazen wrote: > I agree which is why I've included the Validation Bits. A user can then > check the Validation Bits for any field that is of interest but missing. No, no half-baked fields. So you know drivers/edac/mce_amd.c, right? And you know the lengths we go to make an error record as readable as possible? So please apply the same logic and intent here too. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --