public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: geert@linux-m68k.org, andy.shevchenko@gmail.com,
	rabel@robertabel.eu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands
Date: Tue, 27 Feb 2018 21:13:55 +0100	[thread overview]
Message-ID: <20180227201355.GA27525@1wt.eu> (raw)
In-Reply-To: <20180227193118.n33bkbrqxybfhgdc@gmail.com>

On Tue, Feb 27, 2018 at 08:32:21PM +0100, Miguel Ojeda wrote:
> The current version is not parsing multiple x/y commands as the code
> originally intended. On top of that, kstrtoul() expects
> NULL-terminated strings. Finally, the code had to do two passes over
> the string, while now only one is done.
> 
> Some explanations about the supported syntax are added as well.

Thanks Miguel for doing this. To be fair, I personally think that the code
was significantly complexified compared to the original version, just for
the purpose of using one library function designed to multiply by ten and
add a number. Not to mention that it now requires a copy before parsing.
For me it simply means that the initial code change was a wrong idea in
the end. But at least with your version, the bugs introduced by the
previous "fix" should now be gone, which is a good thing.

Thanks,
Willy

  reply	other threads:[~2018-02-27 20:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 19:32 [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands Miguel Ojeda
2018-02-27 20:13 ` Willy Tarreau [this message]
2018-02-27 20:56   ` Miguel Ojeda
2018-02-27 20:52 ` Andy Shevchenko
2018-02-27 21:12   ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180227201355.GA27525@1wt.eu \
    --to=w@1wt.eu \
    --cc=andy.shevchenko@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=rabel@robertabel.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox