From: Willy Tarreau <w@1wt.eu>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: geert@linux-m68k.org, andy.shevchenko@gmail.com,
rabel@robertabel.eu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v3] auxdisplay: charlcd: Fix and clean up handling of x/y commands
Date: Tue, 27 Feb 2018 23:23:00 +0100 [thread overview]
Message-ID: <20180227222300.GA27591@1wt.eu> (raw)
In-Reply-To: <20180227220952.57wc3wpc26b2fdyq@gmail.com>
On Tue, Feb 27, 2018 at 11:09:52PM +0100, Miguel Ojeda wrote:
> The current version is not parsing multiple x/y commands as the code
> originally intended. On top of that, kstrtoul() expects
> NULL-terminated strings. Finally, the code does two passes over
> the string.
>
> Some explanations about the supported syntax are added as well.
Looks much better, thank you ;-)
Willy
next prev parent reply other threads:[~2018-02-27 22:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 22:09 [PATCH RFC v3] auxdisplay: charlcd: Fix and clean up handling of x/y commands Miguel Ojeda
2018-02-27 22:23 ` Willy Tarreau [this message]
2018-02-27 23:23 ` Robert Abel
2018-02-27 23:40 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227222300.GA27591@1wt.eu \
--to=w@1wt.eu \
--cc=andy.shevchenko@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rabel@robertabel.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox