Re: [PATCH v16 06/11] fw_cfg: handle fw_cfg_read_blob() error

Michael S. Tsirkin
2018-02-28T17:33:02Z

> @@ -557,7 +566,10 @@ static int fw_cfg_sysfs_probe(struct platform_device *pdev)
> goto err_probe;
>
> /* get revision number, add matching top-level attribute */
> - fw_cfg_read_blob(FW_CFG_ID, &rev, 0, sizeof(rev));
> + err = fw_cfg_read_blob(FW_CFG_ID, &rev, 0, sizeof(rev));
> + if (err < 0)
> + goto err_probe;
> +
> fw_cfg_rev = le32_to_cpu(rev);
> err = sysfs_create_file(fw_cfg_top_ko, &fw_cfg_rev_attr.attr);
> if (err)

So on this one, maybe we should just drop this attribute.
Does anyone use it?
Removing it will speed up boot slightly.

> --
> 2.16.1.73.g5832b7e9f2