Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note()

Michael S. Tsirkin
2018-03-02T18:03:38Z

On Fri, Mar 02, 2018 at 10:32:04AM +0800, Dave Young wrote:
> Hi
>
> On 02/28/18 at 04:06pm, Marc-André Lureau wrote:
> > The following patch is going to use the symbol from the fw_cfg module,
> > to call the function and write the note location details in the
> > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note.
> >
> > CC: Andrew Morton <akpm@linux-foundation.org>
> > CC: Baoquan He <bhe@redhat.com>
> > CC: Dave Young <dyoung@redhat.com>
> > CC: Dave Young <dyoung@redhat.com>
>
> Above duplicated a CC, btw, I remember both Baoquan and me acked it
> before, you can find the old email and carry the acked-by.

I fixed it but all this is submitter's job really.

> > CC: Hari Bathini <hbathini@linux.vnet.ibm.com>
> > CC: Tony Luck <tony.luck@intel.com>
> > CC: Vivek Goyal <vgoyal@redhat.com>
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Acked-by: Gabriel Somlo <somlo@cmu.edu>
> > ---
> > kernel/crash_core.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> > index 4f63597c824d..a93590cdd9e1 100644
> > --- a/kernel/crash_core.c
> > +++ b/kernel/crash_core.c
> > @@ -376,6 +376,7 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void)
> > {
> > return __pa(vmcoreinfo_note);
> > }
> > +EXPORT_SYMBOL(paddr_vmcoreinfo_note);
> >
> > static int __init crash_save_vmcoreinfo_init(void)
> > {
> > --
> > 2.16.1.73.g5832b7e9f2
> >
>
> Thanks
> Dave