From: Jonathan Cameron <jic23@kernel.org>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: devel@driverdev.osuosl.org, daniel.baluta@gmail.com,
lars@metafoo.de, Michael.Hennerich@analog.com,
linux-iio@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de
Subject: Re: [PATCH 2/6] Staging: iio: adis16209: Change the definition name
Date: Sat, 3 Mar 2018 15:40:29 +0000 [thread overview]
Message-ID: <20180303154029.1d8f30ee@archlinux> (raw)
In-Reply-To: <646c1e2ac1311db1879a5cae58f5f0a0c07114a5.1519995673.git.shreeya.patel23498@gmail.com>
On Fri, 2 Mar 2018 18:53:41 +0530
Shreeya Patel <shreeya.patel23498@gmail.com> wrote:
> The change in the definition name makes it then obvious
> what the units are throughout the driver and there will
> be no need of the comment.
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> drivers/staging/iio/accel/adis16209.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c
> index 58f604d..830c278 100644
> --- a/drivers/staging/iio/accel/adis16209.c
> +++ b/drivers/staging/iio/accel/adis16209.c
> @@ -20,7 +20,7 @@
> #include <linux/iio/buffer.h>
> #include <linux/iio/imu/adis.h>
>
> -#define ADIS16209_STARTUP_DELAY 220 /* ms */
> +#define ADIS16209_STARTUP_DELAY_MS 220
>
> /* Flash memory write count */
> #define ADIS16209_FLASH_CNT 0x00
> @@ -303,7 +303,7 @@ static const struct adis_data adis16209_data = {
>
> .self_test_mask = ADIS16209_MSC_CTRL_SELF_TEST_EN,
> .self_test_no_autoclear = true,
> - .startup_delay = ADIS16209_STARTUP_DELAY,
> + .startup_delay = ADIS16209_STARTUP_DELAY_MS,
>
> .status_error_msgs = adis16209_status_error_msgs,
> .status_error_mask = BIT(ADIS16209_DIAG_STAT_SELFTEST_FAIL_BIT) |
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-03 15:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 13:16 [PATCH 0/6] adis16209 driver cleanup Shreeya Patel
2018-03-02 13:19 ` [PATCH 1/6] Staging: iio: adis16209: Arrange headers in alphabetical order Shreeya Patel
2018-03-03 15:39 ` Jonathan Cameron
2018-03-02 13:23 ` [PATCH 2/6] Staging: iio: adis16209: Change the definition name Shreeya Patel
2018-03-03 15:40 ` Jonathan Cameron [this message]
2018-03-02 13:25 ` [PATCH 3/6] Staging: iio: adis16209: Add _REG postfix for registers Shreeya Patel
2018-03-03 15:42 ` Jonathan Cameron
2018-03-02 13:28 ` [PATCH 4/6] Staging: iio: adis16209: Remove unnecessary comments and group the definitions Shreeya Patel
2018-03-03 15:57 ` Jonathan Cameron
2018-03-02 13:32 ` [PATCH 5/6] Staging: iio: adis16209: Add some informatic comments Shreeya Patel
2018-03-03 16:01 ` Jonathan Cameron
2018-03-03 15:33 ` Shreeya Patel
2018-03-02 13:34 ` [PATCH 6/6] Staging: iio: adis16209: Use sign_extend32 and adjust a switch statement Shreeya Patel
2018-03-03 16:05 ` Jonathan Cameron
2018-03-03 15:37 ` Shreeya Patel
2018-03-03 16:16 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180303154029.1d8f30ee@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=shreeya.patel23498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox