From: Namhyung Kim <namhyung@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-trace-users@vger.kernel.org,
linux-kselftest@vger.kernel.org, shuah@kernel.org,
kernel-team@lge.com
Subject: Re: [PATCH v4 01/19] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol
Date: Mon, 5 Mar 2018 11:28:14 +0900 [thread overview]
Message-ID: <20180305022814.GA8824@sejong> (raw)
In-Reply-To: <20180302153229.dbc4dc9be90a0132b7010010@kernel.org>
Hi Masami,
On Fri, Mar 02, 2018 at 03:32:29PM +0900, Masami Hiramatsu wrote:
> On Fri, 2 Mar 2018 13:49:51 +0900
> Namhyung Kim <namhyung@kernel.org> wrote:
>
> > Hi Masami,
> >
> > On Wed, Feb 28, 2018 at 12:19:53PM +0900, Masami Hiramatsu wrote:
> > > In Documentation/trace/kprobetrace.txt, it says
> > >
> > > @SYM[+|-offs] : Fetch memory at SYM +|- offs (SYM should be a data symbol)
> > >
> > > However, the parser doesn't parse minus offset correctly, since
> > > commit 2fba0c8867af ("tracing/kprobes: Fix probe offset to be
> > > unsigned") drops minus ("-") offset support for kprobe probe
> > > address usage.
> > >
> > > This fixes the traceprobe_split_symbol_offset() to parse minus
> > > offset again with checking the offset range, and add a minus
> > > offset check in kprobe probe address usage.
> >
> > It now parses a minus offset but doesn't allow it, right?
>
> No, split_symbol_offset() is used for 2 cases
> - kprobe-event probe point
> - kporbe-event symbol-based argument
>
> Former one doesn't accept a minus offset, but latter accepts it.
Ah, ok then.
Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> (Frankly to say, I guess no one care about supporting minus offset :P)
:)
Thanks,
Namhyung
next prev parent reply other threads:[~2018-03-05 2:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 3:19 [PATCH v4 00/19] tracing: probeevent: Improve fetcharg features Masami Hiramatsu
2018-02-28 3:19 ` [PATCH v4 01/19] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol Masami Hiramatsu
2018-03-02 4:49 ` Namhyung Kim
2018-03-02 6:32 ` Masami Hiramatsu
2018-03-05 2:28 ` Namhyung Kim [this message]
2018-03-05 10:05 ` Masami Hiramatsu
2018-02-28 3:20 ` [PATCH v4 02/19] selftests: ftrace: Add probe event argument syntax testcase Masami Hiramatsu
2018-02-28 3:20 ` [PATCH v4 03/19] selftests: ftrace: Add a testcase for string type with kprobe_event Masami Hiramatsu
2018-02-28 3:21 ` [PATCH v4 04/19] selftests: ftrace: Add a testcase for probepoint Masami Hiramatsu
2018-02-28 3:21 ` [PATCH v4 05/19] tracing: probeevent: Cleanup print argument functions Masami Hiramatsu
2018-02-28 3:22 ` [PATCH v4 06/19] tracing: probeevent: Cleanup argument field definition Masami Hiramatsu
2018-02-28 3:22 ` [PATCH v4 07/19] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions Masami Hiramatsu
2018-02-28 3:23 ` [PATCH v4 08/19] tracing: probeevent: Introduce new argument fetching code Masami Hiramatsu
2018-02-28 3:23 ` [PATCH v4 09/19] tracing: probeevent: Unify fetch type tables Masami Hiramatsu
2018-02-28 3:24 ` [PATCH v4 10/19] tracing: probeevent: Return consumed bytes of dynamic area Masami Hiramatsu
2018-02-28 3:24 ` [PATCH v4 11/19] tracing: probeevent: Append traceprobe_ for exported function Masami Hiramatsu
2018-02-28 3:25 ` [PATCH v4 12/19] tracing: probeevent: Unify fetch_insn processing common part Masami Hiramatsu
2018-02-28 3:25 ` [PATCH v4 13/19] tracing: probeevent: Add symbol type Masami Hiramatsu
2018-02-28 3:26 ` [PATCH v4 14/19] x86: ptrace: Add function argument access API Masami Hiramatsu
2018-02-28 3:26 ` [PATCH v4 15/19] tracing: probeevent: Add $argN for accessing function args Masami Hiramatsu
2018-02-28 3:27 ` [PATCH v4 16/19] tracing: probeevent: Add array type support Masami Hiramatsu
2018-02-28 3:27 ` [PATCH v4 17/19] selftests: ftrace: Add a testcase for symbol type Masami Hiramatsu
2018-02-28 3:28 ` [PATCH v4 18/19] selftests: ftrace: Add a testcase for $argN with kprobe_event Masami Hiramatsu
2018-03-02 5:31 ` Namhyung Kim
2018-03-02 6:20 ` Masami Hiramatsu
2018-02-28 3:28 ` [PATCH v4 19/19] selftests: ftrace: Add a testcase for array type " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305022814.GA8824@sejong \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox