From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932399AbeCERtZ (ORCPT ); Mon, 5 Mar 2018 12:49:25 -0500 Received: from mga03.intel.com ([134.134.136.65]:12785 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932361AbeCERtX (ORCPT ); Mon, 5 Mar 2018 12:49:23 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,427,1515484800"; d="scan'208";a="39371374" Date: Mon, 5 Mar 2018 10:49:20 -0700 From: Ross Zwisler To: Johannes Thumshirn Cc: Dan Williams , Linux Kernel Mailinglist , Linux NV-DIMM Mailing List Subject: Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg Message-ID: <20180305174920.GA19268@linux.intel.com> References: <20180302122049.13900-1-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180302122049.13900-1-jthumshirn@suse.de> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the nfit module to > do it again. If a user decides to add the +f switch for nfit's dynamic > debug this results in double prints of the function name like the > following: > > [ 2391.935383] acpi_nfit_ctl: nfit ACPI0012:00: acpi_nfit_ctl:nmem8 cmd: 10: func: 1 input length: 0 > > Thus remove the stray __func__ printing. > > Signed-off-by: Johannes Thumshirn This makes sense to me, but I guess we'll see what Dan thinks. If we decide to go this route we may also want to do the same to all the instances of this pattern in the libnvdimm debug output.